Closed Bug 1073851 Opened 7 years ago Closed 7 years ago

jit-test/tests/TypedObject/inlineopaque.js is going to perma-fail when Gecko 35 merges to Aurora

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox34 --- unaffected
firefox35 --- verified

People

(Reporter: RyanVM, Assigned: bhackett1024)

References

Details

Attachments

(1 obsolete file)

This test runs unconditionally whether TypedObjects are supported or not. Once this gets off trunk, we're going to have a bad time.

https://tbpl.mozilla.org/php/getParsedLog.php?id=49028424&tree=Try

20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "--ion-eager --ion-offthread-compile=off")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "--baseline-eager")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "--baseline-eager --no-fpu")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
20:29:06     INFO -  FAIL - TypedObject/inlineopaque.js
20:29:06  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined (code 3, args "--no-baseline --no-ion")
20:29:06     INFO -  INFO exit-status     : 3
20:29:06     INFO -  INFO timed-out       : False
20:29:06     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/TypedObject/inlineopaque.js:1:4 ReferenceError: TypedObject is not defined
Should do the trick.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8496460 - Flags: review?(bhackett1024)
Comment on attachment 8496460 [details] [diff] [review]
add the magic incantation the other tests use

Review of attachment 8496460 [details] [diff] [review]:
-----------------------------------------------------------------

This is the wrong patch, but I just pushed a fix for the test (which I did before I saw you posted a patch, sorry!).  sfink noticed this in his review for bug 1069688 but I forgot to fix it then.

https://hg.mozilla.org/integration/mozilla-inbound/rev/944d31475d2e
Attachment #8496460 - Flags: review?(bhackett1024)
Comment on attachment 8496460 [details] [diff] [review]
add the magic incantation the other tests use

Gah! I can assure you, the actual patch matches what you pushed :P
Attachment #8496460 - Attachment is obsolete: true
Assignee: ryanvm → bhackett1024
https://hg.mozilla.org/mozilla-central/rev/944d31475d2e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.