Refactor the SVG code so that patterns are returned to the point at which we paint

RESOLVED FIXED in mozilla35

Status

()

Core
SVG
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla35
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Right now in the SVG code we do a lot of this:

  CallDownIntoSomethingThatSetsAGfxContextPatternAndLoadsOfOtherStuff();
  aContext->Fill();

This architecture is not compatible with Moz2D where the pattern must be passed to the Fill() (etc.) calls.

To help progress the conversion of the SVG code to Moz2D we should refactor the code to return patterns out to the point at which we paint.
(Assignee)

Comment 1

4 years ago
Created attachment 8496461 [details] [diff] [review]
part 1 - Get rid of nsSVGPaintServerFrame::SetupPaintServer
Attachment #8496461 - Flags: review?(longsonr)
(Assignee)

Comment 2

4 years ago
Created attachment 8496468 [details] [diff] [review]
part 2 - Get rid of nsSVGUtils::SetupCairoStroke
Attachment #8496468 - Flags: review?(longsonr)
Attachment #8496468 - Flags: review?(longsonr) → review-
Attachment #8496461 - Flags: review?(longsonr) → review-
Attachment #8496461 - Flags: review- → review+
Attachment #8496468 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/0218b4fe7bbb
https://hg.mozilla.org/mozilla-central/rev/467d08aeefd0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.