1073924 - Hovering over links in SVG don't cause cursor to change

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Keith Wilkinson]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

1. Display http://travel-tokyo.info/Shinjuku.svg 
    or drag and drop this SVG file onto Firefox. 
2. Hover over the link http://travel-tokyo.info in top left corner. 




Actual results:

Cursor does not change to indicate that the link is clickable. 


Expected results:

Works as expected in Internet Explorer, but I don't know what the SVG spec. says.

Comment 1

[Loic]

Regression range:
good=2014-05-26
bad=2014-05-27
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e86a0d92d174&tochange=cbe4f69c2e9c

Maybe one of these bugs about removing style sheet on-demand for SVG documents.

Comment 2

[Alice0775 White]

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b42ec325e34d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140524122823
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/feff69cd698f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140524130923
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b42ec325e34d&tochange=feff69cd698f

Regressed by: Bug 1013936

Comment 3

[Robert Longson [:longsonr]]

Attachment: pointer.txt

I did think about creating a common.css and loading that always. Would you have preferred that?

Comment 4

[Daniel Holbert [:dholbert]]

Drive-by nit: Might be nice to add/extend a comment to make it clearer that these rules are expected to exactly match the corresponding rules in ua.css (and maybe have a comment in ua.css saying the same).

That way, if we have to update these rules in one spot for some reason, we'll know that we should probably also update the other spot.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8496580 [details] [diff] [review]
pointer.txt

Review of attachment 8496580 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: layout/svg/svg.css
@@ +75,5 @@
>    opacity: inherit;
>  }
>  
> +/* nsDocumentViewer::CreateStyleSet doesn't load ua.css
> + * a few styles are common to html and SVG though

Append ", so we copy the rules below from that file."

Comment 6

[Jonathan Watt [:jwatt]]

I was essentially going for what Daniel said. Feel free to expand on my suggested change to more fully address that.

Comment 7

[Daniel Holbert [:dholbert]]

[Tracking Requested - why for this release]:
Requesting tracking for Firefox 33 -- this was a regression that shipped in Firefox 32 that can break interaction in SVG documents / SVG-based webapps (by not making it clear that links are clickable).  Looks like the fix should be easily & safely backportable, and it'd be nice to have this fixed in 33, so that it's only broken for one release.

Comment 8

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=c766a9876588

Comment 9

[Sylvestre Ledru [:Sylvestre]]

A low risk fix for this will have to land today.

Comment 10

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb41517a5009

Comment 11

[Robert Longson [:longsonr]]

Attachment: as landed on inbound

Approval Request Comment
[Feature/regressing bug #]: bug 1013936
[User impact if declined]: link cursor incorrect
[Describe test coverage new/current, TBPL]: patch includes mochitest
[Risks and why]: very low, just restores the old link link handling css
[String/UUID change made/needed]: none

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8496722 [details] [diff] [review]
as landed on inbound

Approving even it is not in m-c to make sure it is in beta 8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bb93e876e1f7
https://hg.mozilla.org/releases/mozilla-beta/rev/19338c25065c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb41517a5009