Closed Bug 1073964 Opened 9 years ago Closed 9 years ago

Pass a const DrawTarget* through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: jwatt, Assigned: jwatt)

References

(Depends on 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

patch
40.55 KB, patch
bas.schouten
: review+
jwatt
: checkin+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8496565 -
        Flags: review?(matt.woodrow)

    
  
Depends on: 1073960
Keywords: perf

    
    

    
  
Comment on attachment 8496565 [details] [diff] [review]
patch

Drat, this isn't going to give me what I need longer term. I'll want to be able to do things like call DrawTarget::CreateGradientStops() without having to construct a new DrawTarget, so it would be better to pass through a |const DrawTarget*| instead.

        Attachment #8496565 -
        Attachment is obsolete: true

        Attachment #8496565 -
        Flags: review?(matt.woodrow)

    
  
Summary: Pass the backend type and format through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type → Pass a const DrawTarget* through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #8496623 -
        Flags: review?(matt.woodrow)

    
    

    
  
Comment on attachment 8496623 [details] [diff] [review]
patch

Review of attachment 8496623 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/nsSVGPatternFrame.cpp
@@ +373,5 @@
>                              patternHeight / surfaceSize.height);
>    }
>  
>    RefPtr<DrawTarget> dt =
> +    Factory::CreateDrawTarget(aDrawTarget->GetBackendType(), surfaceSize,

This should use CreateSimilar

        Attachment #8496623 -
        Flags: review?(matt.woodrow) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ece627b5e46a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

    
  
Depends on: 1272274

          You need to log in
          before you can comment on or make changes to this bug.