Pass a const DrawTarget* through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Depends on 1 bug, {perf})

Trunk
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

40.55 KB, patch
bas.schouten
: review+
jwatt
: checkin+
Details | Diff | Splinter Review
Assignee

Description

5 years ago
No description provided.
Assignee

Comment 1

5 years ago
Posted patch patch (obsolete) — Splinter Review
Attachment #8496565 - Flags: review?(matt.woodrow)
Assignee

Updated

5 years ago
Depends on: 1073960
Keywords: perf
Assignee

Comment 2

5 years ago
Comment on attachment 8496565 [details] [diff] [review]
patch

Drat, this isn't going to give me what I need longer term. I'll want to be able to do things like call DrawTarget::CreateGradientStops() without having to construct a new DrawTarget, so it would be better to pass through a |const DrawTarget*| instead.
Attachment #8496565 - Attachment is obsolete: true
Attachment #8496565 - Flags: review?(matt.woodrow)
Assignee

Updated

5 years ago
Summary: Pass the backend type and format through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type → Pass a const DrawTarget* through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type
Assignee

Comment 3

5 years ago
Posted patch patchSplinter Review
Attachment #8496623 - Flags: review?(matt.woodrow)
Comment on attachment 8496623 [details] [diff] [review]
patch

Review of attachment 8496623 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/nsSVGPatternFrame.cpp
@@ +373,5 @@
>                              patternHeight / surfaceSize.height);
>    }
>  
>    RefPtr<DrawTarget> dt =
> +    Factory::CreateDrawTarget(aDrawTarget->GetBackendType(), surfaceSize,

This should use CreateSimilar
Attachment #8496623 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/ece627b5e46a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

Updated

3 years ago
Depends on: 1272274
You need to log in before you can comment on or make changes to this bug.