1073964 - Pass a const DrawTarget* through to nsSVGPaintServerFrame::GetPaintServerPattern so that it can create a pattern of the appropriate type

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8496565 [details] [diff] [review]
patch

Drat, this isn't going to give me what I need longer term. I'll want to be able to do things like call DrawTarget::CreateGradientStops() without having to construct a new DrawTarget, so it would be better to pass through a |const DrawTarget*| instead.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8496623 [details] [diff] [review]
patch

Review of attachment 8496623 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/nsSVGPatternFrame.cpp
@@ +373,5 @@
>                              patternHeight / surfaceSize.height);
>    }
>  
>    RefPtr<DrawTarget> dt =
> +    Factory::CreateDrawTarget(aDrawTarget->GetBackendType(), surfaceSize,

This should use CreateSimilar

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8496623 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/ece627b5e46a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ece627b5e46a