1073982 - Add context menu options to show a single calendar and show all calendars

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: show-only-cal.diff

Adds the Show/Hide, Show Only, and Show All calendar options to the calendar list context menu.

Requires the patch in Bug 610152 to prevent view issues when showing multiple calendars at once.

Comment 2

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8496589 [details] [diff] [review]
show-only-cal.diff

Review of attachment 8496589 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with these minor nits:

::: calendar/base/content/calendar-management.js
@@ +211,5 @@
>      // We use the main window's calendar list to ensure that the calendar is visible
>      document.getElementById("calendar-list-tree-widget").ensureCalendarVisible(aCalendar);
>  }
>  
> +function toggleCalendarVisible(aCalendar) {

These functions could use a header with documentation.

@@ +222,5 @@
> +}
> +
> +function showAllCalendars() {
> +    let composite = getCompositeCalendar();
> +    let cals = getCalendarManager().getCalendars({});

cal.getCalendarManager

Comment 3

[Matthew Mecca [:mmecca]]

Attachment: Fix v2

It turns out the Today Pane needed a fix for it's refresh queue similar to the one in Bug 610152. We could probably de-duplicate some code between the Today Pane and the Views, but if it's OK by you I'll leave that for another bug.

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8519496 [details] [diff] [review]
Fix v2

Review of attachment 8519496 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the delay. r=philipp with these minor nits:

::: calendar/locales/en-US/chrome/calendar/calendar.dtd
@@ +242,5 @@
>  <!ENTITY calendar.context.export.accesskey             "E">
>  <!ENTITY calendar.context.properties.label             "Properties">
>  <!ENTITY calendar.context.properties.accesskey         "P">
> +<!ENTITY calendar.context.togglevisible.accesskey      "H">
> +<!ENTITY calendar.context.showonly.accesskey           "O">

You might want to add a localization note here and in the properties file mentioning that this is the access key for the other string.

::: calendar/locales/en-US/chrome/calendar/calendar.properties
@@ +590,5 @@
>  unitHours=#1 hour;#1 hours
>  unitDays=#1 day;#1 days
> +
> +# LOCALIZATION NOTE (showCalendar)
> +# Used in calendar list

Used in the calendar list context menu

Comment 5

[Matthew Mecca [:mmecca]]

Attachment: Fix v3

Patch for check-in

Comment 6

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/d6dc036e0bf9