Closed
Bug 1073984
Opened 10 years ago
Closed 10 years ago
Make SVG geometry painting use a Moz2D Path object directly
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jwatt, Assigned: jwatt)
Details
(Keywords: perf)
Attachments
(1 file)
|
3.70 KB,
patch
|
longsonr
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
SVGPathElement::BuildPath() takes care of the square caps hack, hence why it is removed in this other code.
Attachment #8496592 -
Flags: review?(longsonr)
|
||
Updated•10 years ago
|
Attachment #8496592 -
Flags: review?(longsonr) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8496592 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/89976fb1c8ec
Attachment #8496592 -
Flags: checkin+
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/89976fb1c8ec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
|
Assignee | |
Comment 4•10 years ago
|
||
On our 'svg opacity' tests which draw 2500 rectangles this improved performance on Windows, but regressed Mac: http://graphs.mozilla.org/graph.html#tests=[[225,131,31],[225,131,33],[225,131,35],[225,63,31],[225,63,24]]&sel=1411931432806.7559,1412043050031.6365,73.33333333333326,366.66666666666663&displayrange=90&datatype=running The Mac regression was gained back when I landed bug 1074161. Losing and regaining Mac perf on these two changes makes sense for these tests since this bug temporarily made us use a Moz2D Path objects for rect drawing, whereas bug 1074161 got us back to using rect drawing fast paths (DrawTarget::FillRect/StrokeRect).
Keywords: perf
You need to log in
before you can comment on or make changes to this bug.
Description
•