Closed
Bug 1073998
Opened 10 years ago
Closed 10 years ago
Convert TestWebMBuffered to use files rather than data arrays
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
16.07 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
TestWebMBuffered includes WebM test data as an array in the source because the test infrastructure doesn't provide for file access from GTests yet. Once bug 1054809 is fixed, gWebMData can be removed from TestWebMBuffered.cpp and the test can be convered to use file access. gWebMData is equivalent to content/media/gtest/test.webm.
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8ec8c4b81396
Comment 2•10 years ago
|
||
Comment on attachment 8502235 [details] [diff] [review] bug1073998.patch Review of attachment 8502235 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/gtest/TestWebMBuffered.cpp @@ +32,5 @@ > EXPECT_EQ(parser.mCurrentOffset, 4); > } > > +static void > +ReadFile(const char* aPath, nsTArray<uint8_t>& aBuffer) I've lost count of the number of times in my career that I've written this exact same code...
Attachment #8502235 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdd14734b036
Comment 4•10 years ago
|
||
Backed out for various B2G bustages: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c8dd2b7e1b Example: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2904568&repo=mozilla-inbound
Assignee | ||
Comment 5•10 years ago
|
||
Looks like nullptr is treated as an int on B2G. Pushed a bustage fix to try with more platforms covered: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=40f47709d706
Assignee | ||
Comment 6•10 years ago
|
||
Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/cdbdea7d3705
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cdbdea7d3705
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•