1074011 - Thunderbird's preprocessed channel-prefs.js file needs to be the same for each build

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Port of bug 1070863

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

I won't be able to drive this patch into the tree

Comment 3

[:aceman]

Josiah, can you test and finish this?

Comment 4

[Josiah Bruner [:jsbruner]]

I should be able to, yes. Assigning to myself so I don't forget.

Comment 5

[Josiah Bruner [:jsbruner]]

Comment on attachment 8496634 [details] [diff] [review]
patch

Review of attachment 8496634 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but I don't really know what the GARBAGE stuff does, and that part isn't part of the Fx or SM patch, so I don't feel confident reviewing this.

So I'm going to let Standard8 review it.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8496634 [details] [diff] [review]
patch

Ok, looks good. I'm pretty sure this is needed on aurora & beta, so a=me for landing on those. Please flag any other patches that we need as well.

Comment 7

[Josiah Bruner [:jsbruner]]

Thanks.

Tree's closed currently, so setting checkin-needed in case someone gets to landing this before I do.

Comment 8

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/f0f215cf4940

Comment 9

[Mark Banner (:standard8)]

This already landed on aurora:

https://hg.mozilla.org/releases/comm-aurora/rev/e97c2afe7c85

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/cab722bcb4ab