46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
This bug will address the following things: 1. Create a new tv_apps/ folder in Gaia repo 2. Separate system app of Stingray from phone version system app (i.e. clone system app into tv_apps/) 3. Adjust build script, make sure that we could successfully build gaia within tv_apps/ with GAIA_DEVICE_TYPE=tv
Our build already supports different device type. We will use this mechanism to fork the system app and trying to remove some modules which are not needed by tv_apps.
I've filed bug 1074074 for removing unnecessary modules of tv_apps/system/.
Created attachment 8496753 [details] [review] a copy of system app to tv_apps and change the tv build to use system app in tv_apps This version is a copy of system app without any modification. And I change the configuration to use tv_apps/system when creating TV build. Please review this patch. BTW, I had changed the following files' mode from 755 to 644: mode change 100755 => 100644 build/config/tv/settings.json mode change 100755 => 100644 tv_apps/system/fxa/test/marionette/lib/fxa.js mode change 100755 => 100644 tv_apps/system/fxa/test/marionette/lib/fxa_user.js mode change 100755 => 100644 tv_apps/system/js/icc.js mode change 100755 => 100644 tv_apps/system/js/icc_worker.js mode change 100755 => 100644 tv_apps/system/lockscreen/js/lockscreen.js mode change 100755 => 100644 tv_apps/system/test/marionette/fullscreen-app/index.html mode change 100755 => 100644 tv_apps/system/test/unit/icc_test.js
One more thing: I had disabled lockscreen by default. We don't need it in current use cases.
Comment on attachment 8496753 [details] [review] a copy of system app to tv_apps and change the tv build to use system app in tv_apps Per offline discussion, this effectively fork the System app so it's not the optimal way for us to work on System app for TV. Eventually we want to build System app against device type and with runtime detection etc to make sure System app adopt different devices. For the recent pending TV initiative, let's add a minimum build script that could, say, inject TV specific scripts into the System app for TV builds. After that we can work on modularizing the System app together (i.e. system2 proposal from Alive).
Ok, we should make this bug as invalid. Thanks for the discussion.