1074043 - Status bar icons have wrong color when using activities

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

STR: Open page in browser and share via message app.

Comment 1

[Gregor Wagner [:gwagner]]

[Blocking Requested - why for this release]:

Comment 2

[Gregor Wagner [:gwagner]]

Bad UX

Comment 3

[Aus Lacroix [:aus]]

Looking into this today.

Comment 4

[Aus Lacroix [:aus]]

Attachment: Screenshot - Current State in 2.1

Comment 5

[Aus Lacroix [:aus]]

Attachment: Screenshot - Stuck with bad colour

Comment 6

[Aus Lacroix [:aus]]

Attachment: Pull Request - Listen for activity creation and update titlebar style as expected

Comment 7

[Aus Lacroix [:aus]]

Try run: https://tbpl.mozilla.org/?rev=457f166c88d22ce24cf5e44f4cbdfde88a526d17&tree=Gaia-Try

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8497052 [details] [review]
Pull Request - Listen for activity creation and update titlebar style as expected

As discussion on IRC we tend to use 'activityopening'/'activityopened' event.
Also, in *opening/*opened handler, we should use app.getTopMostWindow() to get the information of the correct app window instance to change the color of statusbar.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8497052 [details] [review]
Pull Request - Listen for activity creation and update titlebar style as expected

r=me with the test comment addressed

Comment 10

[Aus Lacroix [:aus]]

Comment on attachment 8497052 [details] [review]
Pull Request - Listen for activity creation and update titlebar style as expected

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Status Bar UX
[User impact] if declined: Status Bar icons will use the dark theme instead of the light theme. This makes them barely legible at best.
[Testing completed]: On Device (Flame 319M / v180 + Latest Gecko and Gaia) + Unit Tests.
[Risk to taking this patch] (and alternatives if risky): Low. It's a very isolated change backed by tests and manual testing. 
[String changes made]: None.

Comment 11

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/22b1698a71db620b1dd04867aba55efbfd9f23d7

Fixed!

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2:

Flame 2.2 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141001040205
Gaia: 0e280591881d44b80f456bc27e12d9114c218868
Gecko: 14665b1de5ee
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The status bar icons are displayed in white after returning from Message app.

Comment 13

[Aus Lacroix [:aus]]

Attachment: Pull Request - v2.1

Current try run: https://tbpl.mozilla.org/?rev=02665e5bebf69a7c100978b2d86392ef4f25d776&tree=Gaia-Try

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c3c6690d70a05654693f5b4fd86aa7360b05c668

Comment 15

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.1 as well:

Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141003000203
Gaia: 9861c61ec302fb0316c753a2e1c0f592180515fd
Gecko: da68900d1c66
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The status bar icons are displayed in white after returning from Message app.