Intermittent /tests/content/media/webaudio/test/test_bug875221.html | Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self())

RESOLVED FIXED in Firefox 34, Firefox OS v2.1

Status

()

Core
Audio/Video
P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

({intermittent-failure})

Other Branch
mozilla35
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox33 unaffected, firefox34 fixed, firefox35 fixed, firefox-esr31 unaffected, b2g-v2.1 fixed, b2g-v2.2 fixed)

Details

(Whiteboard: [webrtc-uplift])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Likely will happen randomly across tests...  debug only assertion

This could be wallpapered by allowing RunDuringShutdown() to bypass the thread-safety locks (added in bug 1072775).  However, that's not likely safe.  If we could guarantee that all RunDuringShutdown calls were on one thread, then it would be (probably) safe, but we can't.

Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self()), at /builds/slave/m-in-lx-d-00000000000000000000/build/nsprpub/pr/src/pthreads/ptsynch.c:226
Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self()), at /builds/slave/m-in-lx-d-00000000000000000000/build/nsprpub/pr/src/pthreads/ptsynch.c:226
(Assignee)

Comment 1

4 years ago
> This could be wallpapered by allowing RunDuringShutdown() to bypass the
> thread-safety locks (added in bug 1072775).  However, that's not likely
> safe.  If we could guarantee that all RunDuringShutdown calls were on one
> thread, then it would be (probably) safe, but we can't.

Never mind, karlt pointed out to me that AppendMessage() is MainThread-only, so I just need to let it bypass the locks....
(Assignee)

Comment 2

4 years ago
Created attachment 8496683 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)
(Assignee)

Comment 3

4 years ago
Created attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)
(Assignee)

Updated

4 years ago
Attachment #8496683 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

I can integrate the ! into the parenthetical if you want; I left it that way because I found I could read it as "if (!(inRunDuringShutdown))"
Attachment #8496685 - Flags: review?(roc)
(Assignee)

Updated

4 years ago
Assignee: nobody → rjesup
Comment hidden (Treeherder Robot)

Updated

4 years ago
Priority: -- → P1
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/e22cabe63a98
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
We'll need this on Aurora once the other bugs get uplifted.
status-firefox33: --- → unaffected
status-firefox34: --- → affected
status-firefox35: --- → fixed
status-firefox-esr31: --- → unaffected
(Assignee)

Updated

3 years ago
Whiteboard: [webrtc-uplift]
(Assignee)

Comment 74

3 years ago
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

Approval Request Comment
[Feature/regressing bug #]: bug 1072775 (should uplift with it)

[User impact if declined]: Random oranges/ASSERTs in debug builds

[Describe test coverage new/current, TBPL]: all TBPL media tests

[Risks and why]: minimal risk; relaxing new thread-safety assertion to allow the shutdown mode.

[String/UUID change made/needed]: none
Attachment #8496685 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

3 years ago
Blocks: 1072775
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

Aurora+
Attachment #8496685 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/2843cd849c7c
status-b2g-v2.1: --- → fixed
status-b2g-v2.2: --- → fixed
status-firefox34: affected → fixed
You need to log in before you can comment on or make changes to this bug.