1074061 - [Costcontrol]Text and checkbox is shown so transparent.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[vsireesha246]

Steps to Reproduce:

1.Open Usage app and configure it
2.Disable the Mobile usage check box
3.Check the Text and check boxes

Actual:So transparent

Expected:The text and check box should be dark.

Comment 1

[Marina Rodríguez [:mai]]

Hi Sireesha, 
This behaviour is correct. When the checkbox is disabled the text and the checkbox are transparent.

Regards

Comment 2

[vsireesha246]

Attachment: V2.0_Bug_1074061.patch

Hi Mai,

Please see the behavior of enabling and disabling check box below.

Music - select any music file - Share - Ringtones - reserve Use default ringtone text and checkbox.

Please review the attached patch,if you are fine with this patch i will upload PR.

Comment 3

[Marina Rodríguez [:mai]]

Hi Eric,
would you mind review the behaviour of the wifi and mobile checkboxes.

Regards

Comment 4

[Eric Pang [:epang] UX]

(In reply to Marina Rodríguez [:mai] from comment #3)
> Hi Eric,
> would you mind review the behaviour of the wifi and mobile checkboxes.
> 
> Regards

Hi Marina, I'm not the designer of the usage app, but the behavior does seem strange to me as well.  I would expect it to behave like the settings app where only the inner blue and check mark turns on and off.

Comment 5

[vsireesha246]

Hi Kcaldwell,

Would you please do the UX review for this issue and let me know is this patch behavior is correct

Thanks..
Sireesha

Comment 6

[katieC]

Hi Sireesha,

Text and checkbox should not be transparent. The only change should be the state of the checkbox - checked (enabled/on) or unchecked (disabled/off). No transparency of the checkbox when unchecked - the checkbox, visually, should appear as a blue outline, as mentioned above in comment #2.

Comment 7

[Marina Rodríguez [:mai]]

Comment on attachment 8496741 [details] [diff] [review]
V2.0_Bug_1074061.patch

Review of attachment 8496741 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine.
Thanks Sireesha

PS: Please, attach the pr link.

Comment 8

[vsireesha246]

Thanks Mai,by coming monday i will be post PR.

(In reply to Marina Rodríguez [:mai] from comment #7)
> Comment on attachment 8496741 [details] [diff] [review]
> V2.0_Bug_1074061.patch
> 
> Review of attachment 8496741 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works fine.
> Thanks Sireesha
> 
> PS: Please, attach the pr link.

Comment 9

[vsireesha246]

Attachment: Pointer to Pull Request.html

Hi Mai,

Would you please recheck this PR and if it is fine please merge to master.

Thanks..
Sireesha

Comment 10

[Marina Rodríguez [:mai]]

Master:bc12af50fe33ed794d72fc5acfeef94e75169ae0

Comment 11

[Marina Rodríguez [:mai]]

Comment on attachment 8500267 [details]
Pointer to Pull Request.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: Bad UX, the user cannot see the mobile consume because when the checkbox is disabled, the info related with the traffic is hide.
[Testing completed]: Yes, on device
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1e72b5bc019766b6355b93bb8d77c9e99c3e375e

Comment 13

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1 & 2.2.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0

Flame 2.2 version:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1