Closed
Bug 1074081
Opened 10 years ago
Closed 10 years ago
opening a new Private Browsing Window doesn't focus the location bar
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: heycam, Assigned: poiru)
References
Details
Attachments
(2 files, 2 obsolete files)
3.28 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
2.00 KB,
patch
|
Gavin
:
review-
|
Details | Diff | Splinter Review |
STR: 1. Press Ctrl+N. 2. Notice that the location bar does have the focus. 3. Press Ctrl+Shift+P. 4. Notice that the location bar doesn't have the focus.
Updated•10 years ago
|
Keywords: regressionwindow-wanted
Assignee | ||
Comment 1•10 years ago
|
||
This seems to occur only when browser.newtab.url is not about:newtab (I have it set to about:blank).
OS: Linux → All
Hardware: x86_64 → All
Reporter | ||
Comment 2•10 years ago
|
||
Now that you mention it, I did notice this stop working when I changed my browser.newtab.url to about:blank.
Assignee | ||
Comment 3•10 years ago
|
||
Ran mozregression with browser.newtab.url set to about:blank and it pointed to the change[0] in bug 936417. However, the actual regressing change[1] was in bug 799780. [0]: https://hg.mozilla.org/integration/mozilla-inbound/rev/874c670c2cb0 [1]: https://hg.mozilla.org/mozilla-central/rev/129f5457378e#l2.20
Keywords: regressionwindow-wanted
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Attachment #8499981 -
Flags: review?(ehsan.akhgari)
Comment 5•10 years ago
|
||
Comment on attachment 8499981 [details] [diff] [review] Use 'about:privatebrowsing' as BROWSER_NEW_TAB_URL in private windows regardless of the browser.newtab.url pref Review of attachment 8499981 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me, but I prefer Gavin to look at it too. Also, can you please write a test for this? Thanks!
Attachment #8499981 -
Flags: review?(ehsan.akhgari) → review?(gavin.sharp)
Comment 6•10 years ago
|
||
Comment on attachment 8499981 [details] [diff] [review] Use 'about:privatebrowsing' as BROWSER_NEW_TAB_URL in private windows regardless of the browser.newtab.url pref This is probably going to upset the other two people who want their newtab.url to be used for everything, but I guess they can file their own bug!
Attachment #8499981 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 7•10 years ago
|
||
The initial version of browser_privatebrowsing_urlbarfocus.js[0] starts off with a blank page and checks that the location bar isn't focused. It then switches to private browsing mode (which was global at the time) and checks that that the location bar is focused. Finally, it switches back to normal mode and checks that the location bar is no longer focused. When per window PB was introduced, those steps were translated to match the new world order even though most of the steps became unnecessary. This patch removes everything except actually opening a new window and checking for focus. [0]: http://hg.mozilla.org/mozilla-central/diff/315b94a53825/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_urlbarfocus.js
Attachment #8501986 -
Flags: review?(ehsan.akhgari)
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #5) > Also, can you please write a test for this? Thanks! Done.
Attachment #8499981 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8501988 -
Flags: review?(ehsan.akhgari)
Updated•10 years ago
|
Attachment #8501986 -
Flags: review?(ehsan.akhgari) → review+
Updated•10 years ago
|
Attachment #8501988 -
Flags: review?(ehsan.akhgari) → review+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #6) > This is probably going to upset the other two people who want their > newtab.url to be used for everything, but I guess they can file their own > bug! I changed the patch to merely fix the focus issue.
Attachment #8501988 -
Attachment is obsolete: true
Attachment #8504253 -
Flags: review?(gavin.sharp)
Comment 10•10 years ago
|
||
That first patch actually seems preferable to me. It's not clear to me why about:privatebrowsing should override about:newtab but not custom newtab.url values.
Comment 11•10 years ago
|
||
Comment on attachment 8504253 [details] [diff] [review] Part 2: Focus location bar when opening new private windows regardless of the browser.newtab.url pref I agree with Dao, I prefer the first patch.
Attachment #8504253 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a20e3dafc483 https://hg.mozilla.org/integration/mozilla-inbound/rev/428dc3409c5f (In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #11) > I agree with Dao, I prefer the first patch. OK, went with the first patch.
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a20e3dafc483 https://hg.mozilla.org/mozilla-central/rev/428dc3409c5f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment 14•10 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #6) > Comment on attachment 8499981 [details] [diff] [review] > Use 'about:privatebrowsing' as BROWSER_NEW_TAB_URL in private windows > regardless of the browser.newtab.url pref > > This is probably going to upset the other two people who want their > newtab.url to be used for everything, but I guess they can file their own > bug! I am upset by this change... The reason is this: I use the PB mode quite often for regular browsing, and seeing about:privatebrowsing does not provide any useful/new information since I know the effects of PB. So I set browser.newtab.url to about:newtab# to be able to use the tiles (I had to add the # so that it is a user set value). Should I seriously file a new bug when the patch is available here? Another related suggestion that I made is bug 748530.
You need to log in
before you can comment on or make changes to this bug.
Description
•