1074083 - [NFC][KK] Background of shrinking UI would show app icons if website has ever been run at the background

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Gaia-Rev        13973ab50760d1e8bb773082163f0dff19d35a44
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/6e317e075d04
Build-ID        20140928160204
Version         34.0a2

STR:
1. Enable NFC on both phones
2. Open a website
3. Press home button that let the website running at the background
4. Long press home button and select website that let the website running at the foreground
5. Tap two phone together and check the shrinking UI

Expect result:
Shrinking UI shows correcly

Actual result:
Background of shrinking UI would show app icons (http://youtu.be/pXlv66vgswA)

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Obvious error

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: impact lots of users. 

(Check the http://youtu.be/pXlv66vgswA at 15 sec)

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

Hi Alive,
comparing with master, I think the root cause is, when we launch cardview, we didn't close the homescreen app, so I copy part of code from bug 1061324. Could I have your feedback on this patch? I will add tests later if it's ok.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8497379 [details] [review]
PR to 2.1

Sam, please give some advise here for why we have difference between v2.1 and master.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8497379 [details] [review]
PR to 2.1

Forwarding along to Aus who is more familiar with this code then I at this point

Comment 6

[Sam Foster [:sfoster] (he/him)]

> Sam, please give some advise here for why we have difference between v2.1
> and master.

The difference exists because we didn't get uplift approval for bug 1061324 (it was completed too late and risk deemed to high)

Comment 7

[Aus Lacroix [:aus]]

Comment on attachment 8497379 [details] [review]
PR to 2.1

I think this is going the right direction, I left some comments in the pull request. This will need tests to cover those three code paths as well.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8497379 [details] [review]
PR to 2.1

Hi Alive,
could you review this patch for v2.1?
Thanks.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8497379 [details] [review]
PR to 2.1

I personally think we (:aus, :sfoster) should find some time to discuss about code pattern here, but for now let's do the same thing as master.

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No.
[User impact] if declined: see video in comment 0.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]:

Comment 11

[Alison Shiue]

Hi Bhavana, 

Could you please check if you could approve this approval request? Thank you very much.

Comment 12

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Looks like the patch is ready and waiting for approval.
Set the target milestone to end of this week.

Comment 13

[[:fabrice] Fabrice Desré]

Comment on attachment 8498587 [details] [review]
PR to 2.1

Hm, please ask for approval only on fixed bugs.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

There were many pr closed for tree stability, so I open another PR for it, code are the same.

(In reply to George Duan [:gduan] [:喬智] from comment #10)
> Created attachment 8498587 [details] [review]
> PR to 2.1
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): No.
> [User impact] if declined: see video in comment 0.
> [Testing completed]: Yes.
> [Risk to taking this patch] (and alternatives if risky): None.
> [String changes made]:

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8498587 [details] [review]
PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No.
[User impact] if declined: see video in comment 0.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]:

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

2.1: https://github.com/mozilla-b2g/gaia/commit/d71f8804d7229f4b354259d5d8543c25b4796064

Comment 18

[Alison Shiue]

Verified on
Gaia-Rev        55ce3612bd8a8665139d6b85114ce59993a3fa0a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/8811060bf3fe
Build-ID        20141008160203
Version         34.0a2