1074112 - Signing into FxA from Loop closes the FxA tab

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P4)

Description

[Romain Testard [:RT]]

How to reproduce:
1 In the Loop panel click "Sign-in"
2 A new tab opens and the user validates a password
3 The tab closes and the user has no clue what happened

Expected behavior:
1 Either the tab remains open and informs the user that he is signed-in correctly (redirect to https://accounts.firefox.com/settings upon signing in)
2 Or the desktop client informs the user he is signed-in

Comment 1

[Romain Testard [:RT]]

Darrin, do you have an opinion?
Do you agree the current behavior could be improved with (1) at least for Fx34?

Comment 2

[Mark Banner (:standard8)]

Note: the Loop icon on the toolbar does change state from grey to blue, though obviously that's not a totally big change.

Comment 3

[Darrin Henein [:darrin]]

What do we do for Sync? Ryan, any thoughts here?

I'm ok with option 1, keeping the tab open on the user's settings page.

Comment 4

[Matthew N. [:MattN]]

Note that IIRC, closing the tab is controlled by the FxA login page so we can change this from the FxA content server.

Comment 5

[:shell escalante]

waiting on direction decision to align with other apps.  Also this is showing as P4 and we have 2 sprints to close bugs 35 &36 bugs.  we can take ~70-80 bugs total (including regressions).  right now we are at 130.  P4's going to Fx37 (aka post 11/25)

Comment 6

[Ryan Feeley [:rfeeley]]

Attachment: welcome-to-sync.png

We don't close the tab, but rather show this screen (currently the button says "Manage" but it's slated for change). We also have a bug open to port this page to the web (so at the very least we can get the font we use on the web experience).

I recommend going to a white-listed "Welcome to Loop" page on the web that optionally provides a button to open Loop preferences. This gives you the best of both words: remove dependency from Firefox release schedule, and still all some interaction with native browser chrome. When you install a fresh Firefox profile and do the tour, the last page of the tour is about Sync and has this feature.

And heads up that in the not too distant future, we'll likely be replacing the Sync preferences panel with an account panel that contains Sync and other account/browser-connected features.

Comment 7

[Ryan Feeley [:rfeeley]]

For inspiration: http://firsttimeux.tumblr.com/

Comment 8

[Matthew N. [:MattN]]

(In reply to Ryan Feeley from comment #6)
> I recommend going to a white-listed "Welcome to Loop" page on the web that
> optionally provides a button to open Loop preferences.

To clarify, you want this page to show up with every login to Loop? Note that we already have a first-time UX for Loop which is activated via a button in the menu panel the first time it's opened. See bug 1044994.

Comment 9

[Ryan Feeley [:rfeeley]]

Hi Matt: I do think that on sign-in, showing a web page is preferable to closing the tab, even if it's just a lightweight web page. If I were on the Loop team, I'd prefer for this page to be under my control, as the product is evolving rapidly and messaging needs to keep up.

You are also free to use the 'Signed in successfully' variant of the Account Verified screen, though we'll need more info from Chris Karlof for implementation: https://www.dropbox.com/s/oram2kxiv1mv941/Account%20Verified.pdf?dl=0

The {Service} link at the bottom can link to whatever URL you want (I'd recommend linking to a Loop marketing page).

Comment 10

[Chris Karlof [:ckarlof]]

Since the user was trying to sign in to Loop, IMO, the next thing they see should be something about Loop, not FxA. Showing the FxA settings page seems inappropriate and confusing. I had my mind that re-opening the Loop panel after successful login, showing your now logged in state would be clear, but opening some full tab page about Loop also seems fine.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Going to put this as a known issue for 35 release.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Scratch that, I don't think this is clear enough nor are there enough users yet to make this an issue for the majority.

Comment 14

[Adam Roach [:abr]]

To help us understand what the user impact is here, this video of a user narrating his first-time-use experience with Hello is very illuminating; watch from 2:22 to 2:53:

https://www.youtube.com/watch?v=f3hp4lKsIR0#t=2m22s

Comment 16

[Chris Karlof [:ckarlof]]

> To help us understand what the user impact is here, this video of a user narrating his first-time-use experience with Hello is very illuminating; watch from 2:22 to 2:53:

I can see that he was confused because after he signed in, there was no feedback. What do you think should happen after signin completes? From my perspective, after login completes, Hello should either re-open the Hello panel or open some page that tells them more about Hello. Accounts is done.

Comment 17

[Romain Testard [:RT]]

Hi agree with Chris.
So the proposed flow is:
1 Successful validation of password
2 Close FxA tab and open the Hello tab with a message to the user informing of the successful sign-in (maybe a door hanger besides the signed-in ID. 

It also feels that on first time sign-in to FxA we should take the user through a FTU tour similar to what we have for account-less FTU to take the user through the addition of contacts and their first call.

Sevaan, what are your thoughts there?

Comment 18

[Hubert Figuiere [:hub]]

(In reply to Romain Testard [:RT] from comment #17)
> Hi agree with Chris.
> So the proposed flow is:
> 1 Successful validation of password
> 2 Close FxA tab and open the Hello tab with a message to the user informing
> of the successful sign-in (maybe a door hanger besides the signed-in ID. 

Don't close a tab to reopen one. Continue in the same tab.

Comment 19

[Romain Testard [:RT]]

(In reply to Hubert Figuiere [:hub] from comment #18)
> (In reply to Romain Testard [:RT] from comment #17)
> > Hi agree with Chris.
> > So the proposed flow is:
> > 1 Successful validation of password
> > 2 Close FxA tab and open the Hello tab with a message to the user informing
> > of the successful sign-in (maybe a door hanger besides the signed-in ID. 
> 
> Don't close a tab to reopen one. Continue in the same tab.

Apologies, I meant to say "Open the Hello panel":
1 Successful validation of password
2 Close FxA tab and open the Hello panel with a message to the user informing of the successful sign-in (maybe a door hanger besides the signed-in ID.

Comment 20

[Hubert Figuiere [:hub]]

The problem with closing the tab is what bug 1131114 says: it also prevents the password manager to save the password. Also bug 1109596. Neither of the use case is addressed by your proposal.

Comment 21

[Chris Karlof [:ckarlof]]

Not closing the tab is pretty straightforward. The open issue is around what the tab should display after login is successful.

Comment 22

[Hubert Figuiere [:hub]]

We could have a simple page that have:

1. a message saying login successful with the actually account info (name / address)
2. show the next step with a screen shot: where to click, etc
3. a button "close this" that indeed would close the tab.

This is centered around giving the user info and guidance.
Users that know will just click the button "close this".

Comment 23

[Sevaan Franks [:sevaan]]

I think there are some good ideas here. Let's pop the panel, and keep the tab open to a page similar to the tour page: https://www.mozilla.org/en-US/firefox/38.0a1/hello/start/

Basic messaging: Thanks for logging in, now you can add contacts and make direct calls. Click here to learn more.

Even better, a button to help users import their contacts so they can get started faster.

Comment 24

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.