1074120 - [Bluetooth] OPP file transfer maybe broken

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

OPP transfer don't work any longer. I observed this on Flame-kk with v2.1, but master is probably also affected. STR

  - switch on and off BT once
  - switch on BT for a second time
  - observe error 'Accept failed: 5' in logcat

Expected:

  - no error, OPP works

Actual result 

  - OPP doesn't work

The error message is a result of bug 1063066, and I guess the OPP problem is as well.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We should first figure out, why the error message shows up and why the socket get's closed during initialization.

And we might also simply remove the |Proceed| from the socket's close code and let it stop silently.

Comment 2

[Ben Tian (inactive)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> We should first figure out, why the error message shows up and why the
> socket get's closed during initialization.

The error message shows since [1] closes the listening socket. When establishing outgoing connection, gecko closes the listening socket first and then creates another socket to connect to remote device.

[1] http://hg.mozilla.org/mozilla-central/file/9d66436af432/dom/bluetooth/bluedroid/BluetoothSocketHALInterface.cpp#l529

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Ben Tian [:btian] from comment #2)
> (In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> > We should first figure out, why the error message shows up and why the
> > socket get's closed during initialization.
> 
> The error message shows since [1] closes the listening socket. When
> establishing outgoing connection, gecko closes the listening socket first
> and then creates another socket to connect to remote device.
> 
> [1]
> http://hg.mozilla.org/mozilla-central/file/9d66436af432/dom/bluetooth/
> bluedroid/BluetoothSocketHALInterface.cpp#l529

OK, makes sense. I think we should somehow handle this case or don't call |Proceed|.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hmm, I restarted the phone and did some more testing, but OPP seems to work now. Maybe this is was transient error because of something else... I suggest to keep this bug open for a few days and watch out for the problem.

Comment 5

[Ben Tian (inactive)]

Thomas, shall we close this bug?

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Sure. I haven't seen this bug any more, and no one else has reported a similar thing. Let's close it.