Closed Bug 1074144 Opened 11 years ago Closed 11 years ago

Fix Email app oauth2 authentication failure

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: Bebe, Assigned: RobertC)

Details

Attachments

(2 files)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24515
46 bytes, text/x-github-pull-request
RobertC
: review+
viorela
: review+
Details | Review
Uplift to v2.1
46 bytes, text/x-github-pull-request
viorela
: review+
Details | Review
Description: Email dev's moved the oauth2 authentication in to the email app iframe because of bug 1069412. Update the test's to use the same behaviour.
Attachment #8496804 - Flags: review?(viorela.ioia)
Attachment #8496804 - Flags: review?(robert.chira)
Attachment #8496804 - Flags: review?(dave.hunt)
Attachment #8496804 - Flags: review?(robert.chira) → review+
Comment on attachment 8496804 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24515 r+
Attachment #8496804 - Flags: review?(viorela.ioia) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #8496804 - Flags: review?(dave.hunt)
Attached file Uplift to v2.1 —
Attachment #8498825 - Flags: review?(viorela.ioia)
Attachment #8498825 - Flags: review?(florin.strugariu)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8498825 [details] [review] Uplift to v2.1 Merged in v2.1: https://github.com/mozilla-b2g/gaia/commit/ff648c94adf63e5b7201d78cfa330ee087172479
Attachment #8498825 - Flags: review?(viorela.ioia)
Attachment #8498825 - Flags: review?(florin.strugariu)
Attachment #8498825 - Flags: review+
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
(In reply to Viorela Ioia [:viorela] from comment #5) > Comment on attachment 8498825 [details] [review] > Uplift to v2.1 > > Merged in v2.1: > https://github.com/mozilla-b2g/gaia/commit/ > ff648c94adf63e5b7201d78cfa330ee087172479 It's been policy for a month now that all patches must have approval before uplift, regardless of blocking status. Why was this landed outside of that policy?
Assignee: nobody → robert.chira
status-b2g-v2.1: --- → fixed
status-b2g-v2.2: --- → fixed
Flags: needinfo?(viorela.ioia)
Target Milestone: --- → 2.1 S6 (10oct)
Ah, nevermind, this was test-only. Carry on :)
Flags: needinfo?(viorela.ioia)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: