Closed Bug 1074272 Opened 5 years ago Closed 5 years ago

Use exception mode 0 for our D3D11 device

Categories

(Core :: Graphics, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox33 + verified
firefox34 + verified
firefox35 + verified

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

This is the D3D11 equivalent for bug 768395.
Attachment #8496932 - Flags: review?(jmuizelaar)
Going to mark tracking flags since this showed up in recent FF33 stability analysis and is high-reward and low-risk.
Attachment #8496932 - Flags: review?(jmuizelaar) → review+
Attachment #8496933 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/73a12dc3393d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8496933 [details] [diff] [review]
Set exception mode for D3D11 devices to 0 (patch that applies to beta)

Approval Request Comment
[Feature/regressing bug #]: OMTC
[User impact if declined]: Some more crashes, #10 top crasher for last beta build
[Describe test coverage new/current, TBPL]: Nightly
[Risks and why]: Very low, just disabling exception firing
[String/UUID change made/needed]: None
Attachment #8496933 - Flags: approval-mozilla-beta?
Comment on attachment 8496933 [details] [diff] [review]
Set exception mode for D3D11 devices to 0 (patch that applies to beta)

Bas, any reason why you don't want that to aurora?
Attachment #8496933 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(bas)
(In reply to Sylvestre Ledru [:sylvestre] from comment #5)
> Comment on attachment 8496933 [details] [diff] [review]
> Set exception mode for D3D11 devices to 0 (patch that applies to beta)
> 
> Bas, any reason why you don't want that to aurora?

No, but I haven't checked whether it applies and builds yet there, and I was in a little more of a rush for beta :).
Flags: needinfo?(bas)
Crash Signature: [@ CDevice::DriverInternalErrorCB(long)]
Keywords: crash
Bas - Now that this is on beta, can you please look into applying the fix on aurora as well?
Flags: needinfo?(bas)
Bas - ping. 34 uplifts to beta on Monday. Do you have time to get the Aurora patch ready to land before the merge?
Flags: needinfo?(bas)
(In reply to Lawrence Mandel [:lmandel] from comment #9)
> Bas - ping. 34 uplifts to beta on Monday. Do you have time to get the Aurora
> patch ready to land before the merge?

If the beta one applies, and I expect it will, it's the same patch :). I'll check this weekend.
Looking in Socorro [1] for crashes with this signature over the past 4 weeks, there are no crashes on Firefox 33 releases or on Firefox 35 builds, and only 1 crash on Firefox 34 Beta.

[1] - https://crash-stats.mozilla.com/report/list?signature=CDevice%3A%3ADriverInternalErrorCB%28long%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2014-12-12+10%3A00%3A00&range_value=4#reports
See Also: → 1204321
You need to log in before you can comment on or make changes to this bug.