Closed
Bug 1074286
Opened 10 years ago
Closed 10 years ago
Fix Headers::Fill(const Headers&, ErrorResult&)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: nsm, Assigned: nsm)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
It should use Append instead of just copying the nsTArray so that the guard can be enforced.
|
||
Comment 1•10 years ago
|
||
We should add a test for this case as well.
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8496972 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8496972 [details] [diff] [review] Fix Headers::Fill(const Headers&, ErrorResult&) I still think we can should add a test case for this in dom/tests/mochitest/fetch/test_headers_mainthread.js. Those tests already manipulate the guard.
Attachment #8496972 -
Flags: review?(bkelly) → review+
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c766099a83c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•