1074294 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Convert SVGAutoRenderState to act on a Moz2D DrawTarget

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Finish the conversion of nsSVGPathGeometryFrame::Render to Moz2D

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

Comment 4

[Robert Longson [:longsonr]]

Comment on attachment 8496998 [details] [diff] [review]
part 2 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

>   if ((aRenderComponents & eRenderFill)) {

Nit: don't need two brackets here. Since you're changing this area anyway.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8496958 [details] [diff] [review]
part 1 - Convert SVGAutoRenderState to act on a Moz2D DrawTarget

https://hg.mozilla.org/integration/mozilla-inbound/rev/7879734700ce

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8496998 [details] [diff] [review]
part 2 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd87b4cb26c1

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7879734700ce
https://hg.mozilla.org/mozilla-central/rev/cd87b4cb26c1

Comment 9

[Jonathan Watt [:jwatt]]

This improved performance on bug 609361's testcase by an order of magnitude (see bug 609361 comment 39), and bug 554004's testcase by about 15% (see bug 554004 comment 14).