Closed Bug 1074294 Opened 5 years ago Closed 5 years ago

Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 2 open bugs)

Details

(Keywords: perf)

Attachments

(2 files, 1 obsolete file)

No description provided.
Attachment #8496959 - Attachment is obsolete: true
Attachment #8496959 - Flags: review?(longsonr)
Summary: Finish the conversion of nsSVGPathGeometryFrame::Render to Moz2D → Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget
Attachment #8496958 - Flags: review?(longsonr) → review+
Comment on attachment 8496998 [details] [diff] [review]
part 2 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

>   if ((aRenderComponents & eRenderFill)) {

Nit: don't need two brackets here. Since you're changing this area anyway.
Attachment #8496998 - Flags: review?(longsonr) → review+
Depends on: 1074475
Comment on attachment 8496958 [details] [diff] [review]
part 1 - Convert SVGAutoRenderState to act on a Moz2D DrawTarget

https://hg.mozilla.org/integration/mozilla-inbound/rev/7879734700ce
Attachment #8496958 - Flags: checkin+
Comment on attachment 8496998 [details] [diff] [review]
part 2 - Convert nsSVGPathGeometryFrame::Render() to render directly using the Moz2D DrawTarget

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd87b4cb26c1
Attachment #8496998 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/7879734700ce
https://hg.mozilla.org/mozilla-central/rev/cd87b4cb26c1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Duplicate of this bug: 1072339
Blocks: 703159
Blocks: 609361
This improved performance on bug 609361's testcase by an order of magnitude (see bug 609361 comment 39), and bug 554004's testcase by about 15% (see bug 554004 comment 14).
Blocks: 554004
Keywords: perf
Depends on: 1117514
You need to log in before you can comment on or make changes to this bug.