1074413 - java.lang.NullPointerException at org.mozilla.gecko.gfx.JavaPanZoomController.handleMessage(JavaPanZoomController.java:278)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

D/GeckoBrowserApp( 6448): BrowserApp.onTabChanged: 5: CLOSED
E/GeckoPanZoomController( 6448): Exception handling message "Tab:HasTouchListener":
E/GeckoPanZoomController( 6448): java.lang.NullPointerException
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.gfx.JavaPanZoomController.handleMessage(JavaPanZoomController.java:278)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:210)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:180)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2327)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:365)
E/GeckoPanZoomController( 6448): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

I am getting this on tab close.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Just needs a null check I guess. If the tab is closed in java while there's a message in the pipe from the JS side we can get a null tab returned at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/JavaPanZoomController.java?rev=070491691b4e#277

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: tab-nullcheck v0.1

Adds a null check

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/fb47e92d7752

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb47e92d7752

Comment 5

[u279076]

Aaron, can you please confirm that you no longer see this?