1074459 - Accessibility review for new login

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

We have new login UX and frontend. Yay!

Let's make sure it's nice and accessible. Aki is going to help us out by doing a review with this lens.

Cade is going to update a public link with the latest work by Wednesday morning... Cade if you could update here when ready that would be helpful. We'll aim to complete this for the next heartbeat.

Comment 1

[Chris DeCairos (:cade)]

The test app is running here: http://webmaker-handshake.herokuapp.com/

We're in the middle of a re-write, so it's possible it'll change a bit in the coming week.

Comment 2

[Aki Rose Braun [:akirose]]

A couple notes:

"Create a Webmaker account" modal
1. "log in with Persona" should be a button with a class of "btn btn-link" so tab focus works properly on Macs with the "Text boxes and lists only" tab option (the default) selected
2. the email element should have an id of email. currently the label isn't assigned to anything so voiceover calls it "required text"
3. dynamic error message should appear *below* form fields, otherwise it moves the location of the form fields and can disorient the person using it
4. *ideally* the checkbox input for terms & privacy policy should be outside the label. either way, it should have an id, and the label should be for= that id.

"Welcome to Webmaker" modal
1. "Explore the rest of Webmaker" should be a button with link class as well


The experience itself is totally spot-on. I love it. <3 big ups!

Comment 3

[Matthew Willse [:mattheww]]

Thanks Aki. Nice, clear feedback. 

These all seem like pretty small fixes that could be implemented pre- or post-launch.

Comment 4

[Aki Rose Braun [:akirose]]

Same notes for IE, Windows Narrator basically works the same as voiceover.

Comment 5

[Matt Thompson (@OpenMatt :OpenMatt)]

* the [oct17] train has now left the station
* so please update with [oct31], [nov14], [nov28], etc.

Comment 6

[Matt Thompson (@OpenMatt :OpenMatt)]

* [oct17] has passed. Please update the whiteboard.

Comment 7

[Matt Thompson (@OpenMatt :OpenMatt)]

* [nov14] is past -- please update to [nov28] train or later

Comment 8

[Matt Thompson (@OpenMatt :OpenMatt)]

* Are we still doing this?

Comment 9

[Chris DeCairos (:cade)]

I'll take this and make sure everything's working from an accessibility point of view.

Comment 10

[Chris DeCairos (:cade)]

I have no idea how to tweak those ui bits without breaking anything.

Ricardo: can you help?

Comment 11

[Ricardo Vazquez [:ricardo]]

I will investigate.

Comment 12

[Chris DeCairos (:cade)]

We've patched up all the issues caught in the a11y review, gonna close this one now.

Comment 13

[Ricardo Vazquez [:ricardo]]

\o/