1074501 - Multiple frame-scripts not executing in same scope in FF33b when injected using browser.messageManager.loadFrameScript

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[dgdawg]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 Safari/537.36

Steps to reproduce:

Tried to inject multiple frame scripts in a <browser> from an extension. 


Actual results:

The individual scripts are executed but are not in the same scope.


Expected results:

All the scripts injected at the same time on the same <browser> should be executed in the same scope.
This was working fine until FF 32.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Is this because of bug 673569 ?

Comment 2

[dgdawg]

It does seem to be related to bug 673569 . But I couldn't figure out a solution to my problem. Pls suggest if there is an alternative way (like a arg that I can pass to loadFrameScript  so that all scripts load in the same scope)

Comment 3

[dgdawg]

Will try to see if setting the 3rd arg to loadFrameScript(aURL, aAllowDelayedLoad, aRunInGlobalScope); makes every script load in global scope.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The aRunInGlobalScope argument will make everything run in global scope. However, keep in mind that |this| will still refer to the single global object shared by all frame scripts. So rather than using aRunInGlobalScope, you can replace |x| with |this.x| for every variable x that needs to be shared between scripts. That way you won't accidentally get name collisions.

Comment 5

[dgdawg]

Verified both aRunInGlobalScope and using |this| to share variables between scripts works.