1074515 - Dragging/dropping a revision from the list of revisions into the classification field should be handled specially.

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P4)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Typically on TBPL if I'm going to mass-classify failures from something that was later backed out, I would select all of the failing jobs, open the "Add a comment" dialog, then drag the revision ID link from the backout commit into the Add a comment" box. TBPL would strip out everything from the dropped URL except the revision ID.

In treeherder, the equivalent would be me selecting all of the failed jobs, then dragging the backout revision link into the pinboard's classification box. Dropping the revision link into that box should strip out everything from the link except the revision ID (I guess; I don't really care about this part, it's just parity with TBPL...) and automatically change the classification type to be "fixed by commit".

Comment 1

[Ed Morley [:emorley]]

I didn't even know TBPL did that - not sure if it was by design or accidental (via whatever jquery plugin was used for the submit form).

My TBPL workflow was "double click next to the SHA to select the entire string, press ctrl+c, select the jobs, press 'c', ctrl+V, submit".

This bug is really two things:
1) Handle dropping of links dragged from elsewhere in the UI
2) Automatically set the classification to "fixed by commit", if the message contains a SHA (regardless of where that SHA came from).

Comment 2

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #1)
> My TBPL workflow was "double click next to the SHA to select the entire
> string, press ctrl+c, select the jobs, press 'c', ctrl+V, submit".

This workflow is actually broken in treeherder - I can't select the SHA properly. I'll file another bug.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:bug1074515 > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798725 [details] [review]
[treeherder] KWierso:bug1074515 > mozilla:master

I don't know if we still want to do this, but here's something that worked for me locally. Bunch of code cribbed directly from tbpl, though the jquery .live() appears to be deprecated and removed from current jquery.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798725 [details] [review]
[treeherder] KWierso:bug1074515 > mozilla:master

Cam, Ed suggested I flag you for this. I'm personally okay with just closing this without landing anything as I've stopped using this workflow since the transition to Treeherder due to this bug, and I don't think I'd really fall back into that workflow.

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8798725 [details] [review]
[treeherder] KWierso:bug1074515 > mozilla:master

I'd be inclined to just close the bug as wontfix if nobody is asking for it anymore.  I would imagine someone would have chimed in that they really missed this by now.  I'd also rather not add too much raw jquery into the code unless there was a real need for it.

Comment 7

[Ed Morley [:emorley]]

We can always reopen if there's more demand in the future :-)