Closed Bug 1074536 Opened 10 years ago Closed 9 years ago

Padding for integrated Statusbar overlaps with addressbar when statusbar is hidden

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

35 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox35 affected, firefox36 affected, firefox37 fixed)

RESOLVED FIXED
Tracking Status
firefox35 --- affected
firefox36 --- affected
firefox37 --- fixed

People

(Reporter: Ceremony, Unassigned)

References

Details

(Keywords: regression)

Attachments

(3 files)

Since a few nightlies ago, FF integrates the statusbar in firefox with a sleek new gradient, just like most launchers do: blending the statusbar over the desktop wallpaper.

Unfortunately, there seems to be an issue once you decide to hide the statusbar, as several custom ROMs allow you to do: FF no longer adds the top-padding to the address bar, but still keeps the background and size for the statusbar, thus hiding a portion at the top of the screen at all times. Please look at the two screenshots.
Thanks for reporting.
Blocks: 1056002
Status: UNCONFIRMED → NEW
tracking-fennec: --- → ?
Ever confirmed: true
tracking-fennec: ? → 35+
Might be fixed whenever bug 1074924 is fixed. Looks like the cause might be related.
Keywords: regression
(In reply to David H. from comment #0)
> Created attachment 8497156 [details]
> The statusbar (and navigation) hidden
> 
> Since a few nightlies ago, FF integrates the statusbar in firefox with a
> sleek new gradient, just like most launchers do: blending the statusbar over
> the desktop wallpaper.
> 
> Unfortunately, there seems to be an issue once you decide to hide the
> statusbar, as several custom ROMs allow you to do: FF no longer adds the
> top-padding to the address bar, but still keeps the background and size for
> the statusbar, thus hiding a portion at the top of the screen at all times.
> Please look at the two screenshots.

David, do you happen to know what mechanisms these custom ROMS use to hide the statusbar? Is it possible to track the statubar visibility using the standard APIs such as getSystemUiVisibility()?
Flags: needinfo?(henningerdavid)
(In reply to Gian-Carlo Pascutto [:gcp] from comment #3)
> Might be fixed whenever bug 1074924 is fixed. Looks like the cause might be
> related.

Doesn't seem like the same cause. Bug 1074924 is essentially about fullscreen mode. This bug is more about custom ROMs hiding the statusbar.
(In reply to Lucas Rocha (:lucasr) from comment #4)
> (In reply to David H. from comment #0)
> > Created attachment 8497156 [details]
> > The statusbar (and navigation) hidden
> > 
> > Since a few nightlies ago, FF integrates the statusbar in firefox with a
> > sleek new gradient, just like most launchers do: blending the statusbar over
> > the desktop wallpaper.
> > 
> > Unfortunately, there seems to be an issue once you decide to hide the
> > statusbar, as several custom ROMs allow you to do: FF no longer adds the
> > top-padding to the address bar, but still keeps the background and size for
> > the statusbar, thus hiding a portion at the top of the screen at all times.
> > Please look at the two screenshots.
> 
> David, do you happen to know what mechanisms these custom ROMS use to hide
> the statusbar? Is it possible to track the statubar visibility using the
> standard APIs such as getSystemUiVisibility()?
I looked into where the feature originated and it seems to be an official android feature, first found in KitKat (4.4): https://developer.android.com/training/system-ui/immersive.html

So yes, getSystemUiVisibility() should be get you the phones statusbar state. Im using mode #4 ( IMMERSIVE_STICKY)
Flags: needinfo?(henningerdavid)
David, could you please try this APK and let me know if that fixes this issue in your ROM?
https://dl.dropboxusercontent.com/u/1187037/fennec-statusbar-fix.apk

It will show up as 'Fennec lucasr' in the app launcher.
Flags: needinfo?(henningerdavid)
(In reply to Lucas Rocha (:lucasr) from comment #7)
> David, could you please try this APK and let me know if that fixes this
> issue in your ROM?
> 
> It will show up as 'Fennec lucasr' in the app launcher.
It works! However it still shows up on start for like 0.5 to 1 second, until firefox is fully functional (initializing phase I'd call it)

Also, switching fullscreen mode on/off while ff is up and running works as well!
Flags: needinfo?(henningerdavid)
(In reply to David H. from comment #8)
> (In reply to Lucas Rocha (:lucasr) from comment #7)
> > David, could you please try this APK and let me know if that fixes this
> > issue in your ROM?
> > 
> > It will show up as 'Fennec lucasr' in the app launcher.
> It works! However it still shows up on start for like 0.5 to 1 second, until
> firefox is fully functional (initializing phase I'd call it)

Do other apps behave differently? I'm afraid we can't do anything about this as IMMERSIVE is not the default system UI visibility.

Do you know of any docs explaining how custom ROMs implement this feature?
Comment on attachment 8503101 [details] [diff] [review]
Hide statubar tint whenever statusbar is hidden (r=mfinkle)

Consider this a generalization of the patch in bug 1074924. I wonder why we were using 0/1 in the setSystemUiVisibility() calls. This is just not right.

Tested this on pre and post 11 devices. Seems to be working fine.
Attachment #8503101 - Flags: review?(mark.finkle)
Comment on attachment 8503101 [details] [diff] [review]
Hide statubar tint whenever statusbar is hidden (r=mfinkle)

I wonder if BaseGeckoInterface.setFullScreen and GeckoApp.setFullScreen could be merged somehow in the future.
Attachment #8503101 - Flags: review?(mark.finkle) → review+
Blocks: 1081153
https://hg.mozilla.org/integration/fx-team/rev/433cb9e553e1

Filed bug 1081153 to track the setFullscreen() refactoring.
(In reply to Lucas Rocha (:lucasr) from comment #10)
> (In reply to David H. from comment #8)
> > (In reply to Lucas Rocha (:lucasr) from comment #7)
> > > David, could you please try this APK and let me know if that fixes this
> > > issue in your ROM?
> > > 
> > > It will show up as 'Fennec lucasr' in the app launcher.
> > It works! However it still shows up on start for like 0.5 to 1 second, until
> > firefox is fully functional (initializing phase I'd call it)
> 
> Do other apps behave differently? I'm afraid we can't do anything about this
> as IMMERSIVE is not the default system UI visibility.
> 
> Do you know of any docs explaining how custom ROMs implement this feature?

im sorry but I don't... However, if you ask at http://forum.xda-developers.com, youll get a response within minutes (probably).

speaking of xda, there is also an app that can force immersive mode: http://forum.xda-developers.com/xposed/modules/mod-force-immersive-mode-selected-apps-t2707265 (requires a rooted phone!)

It didnt work for me though, as it conflicts with the built in immersive mode feature of my rom, but should work for rooted stock roms!
unfortunately, patch does not fully fix the issue: when I focus on the address bar, the keyboard pops up and so does the grey bar. once I close the keyboard, the status bar background disappears as well.
Assignee: nobody → lucasr.at.mozilla
(In reply to David H. from comment #15)
> unfortunately, patch does not fully fix the issue: when I focus on the
> address bar, the keyboard pops up and so does the grey bar. once I close the
> keyboard, the status bar background disappears as well.
I should note, that this always happens once the keyboard pops up, not just when i enter something in the address bar.
Reading this comments it seems that ROM handling this in different ways. So if it would much time to adapt to different ROM versions it may be better to leave the decision to show the bar or not is a user setting.
Dropping the tracking since this is a custom ROM
tracking-fennec: 35+ → ---
One of the more recent nightly builds contained a fix for this. The top bar no longer shows up, when the keyboard appears. I consider this issue as fixed!

Thanks!
I am using a official Google Android Rom and with the latest version of Nightly 36.0a1 2014-11-26 and the bar is still activated when using the keyboard and stays blocking the URL bar during the session.

Since a few day's am I using Opera browser, which is not as refined as FireFox but a lot faster. It is a  pity to leave Mozilla Fennec on my portable devices after a few years using it in good but also some bad times.
I have to correct my statement about the speed op FireFox. I had adblocker and ghostery activated and that slows down FireFox considerable. The difference is between the two browsers is now small in favour of Opera.

Missing now the adblocker and Ghostery is now compensated by running my own DNSmasq deamon and filtering it by using a hosts file with all the unwanted domains in it.

I will try time by time if FireFox Nightly is wihtout the tinted bar on the top so I change back to a more refined browser and now also here faster by omitting the two add-ons.
Assignee: lucasr.at.mozilla → nobody
This should be fixed by the backout (and its uplift) of bug 1056002 to 37.

Please reopen (or comment) if you disagree.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.