Closed
Bug 1074548
Opened 10 years ago
Closed 10 years ago
Eager allocation of webrtc trace buffers was supposed to be turned off in Beta and Release
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: regression, Whiteboard: [MemShrink:P2][webrtc-uplift])
Attachments
(1 file)
992 bytes,
patch
|
ted
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
In Bug 970713 we said that lazy allocation of the ~8MB of webrtc trace buffers would need to be re-enabled for Beta and Release, and it wasn't. This landed in 32, so 32 is the only release version to go out with it. It's a single pref in gyp.mozbuild. We need to check 2.0 as well.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8497170 -
Flags: review?(khuey)
Comment on attachment 8497170 [details] [diff] [review] lazy-allocate webrtc trace buffers in RELEASE_BUILDs Review of attachment 8497170 [details] [diff] [review]: ----------------------------------------------------------------- I don't know if this is actually defined in this file, because I don't know how any of the gyp integration works. 302 ted.
Attachment #8497170 -
Flags: review?(khuey) → review?(ted)
Updated•10 years ago
|
Attachment #8497170 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e640b23767a5
Whiteboard: [memshrink] → [memshrink][webrtc-uplift]
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8497170 [details] [diff] [review] lazy-allocate webrtc trace buffers in RELEASE_BUILDs Approval Request Comment [Feature/regressing bug #]: bug 970713 [User impact if declined]: 8MB memory use if webrtc or getusermedia is used [Describe test coverage new/current, TBPL]: n/a (or if you prefer http://areweslimyet.com/ but it doesn't touch webrtc/gUM) [Risks and why]: virtually none. this was used in the past, and was supposed to be disabled on nightly and aurora only. [String/UUID change made/needed]: none
Attachment #8497170 -
Flags: approval-mozilla-beta?
Attachment #8497170 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Whiteboard: [memshrink][webrtc-uplift] → [MemShrink:P2][webrtc-uplift]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e640b23767a5
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8497170 -
Flags: approval-mozilla-beta?
Attachment #8497170 -
Flags: approval-mozilla-beta+
Attachment #8497170 -
Flags: approval-mozilla-aurora?
Attachment #8497170 -
Flags: approval-mozilla-aurora+
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8e8a24322b9a https://hg.mozilla.org/releases/mozilla-beta/rev/002f9202019b
You need to log in
before you can comment on or make changes to this bug.
Description
•