1074594 - Stop inverting the transform in nsSVGUtils::GetStrokeTransform, give it a more performant signature, and a better name

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

nsSVGUtils::GetStrokeTransform is causing be problems because it inverts the transform before returning it and some callers (pre-existing, and ones I'm adding) have to invert it back again. This is causing some irritating rounding errors and causing unnecessary matrix multiplication. I want to change it so that it doesn't do the Invert() call, and callers who require inversion do that.

While here this function can be given a better signature and a better name. Also I want to rename the variables in the callers that accept the returned result to say what the transform is, not just some "stroke transform" name which makes it hard to reason about what is going on.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8497231 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/9647b50b12af

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9647b50b12af