Closed Bug 1074622 Opened 10 years ago Closed 10 years ago

[Stingray] Scaffold the TV browser

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yifan, Unassigned)

References

Details

(Whiteboard: [w1])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
timdream
: review+
jj.evelyn
: review+
rexboy
: review+
Details | Review
Scaffold a TV browser app in gaia/tv_apps folder base on the original browser for v2.0.
Blocks: 1074624
Blocks: 1074617
Blocks: 1074625
Whiteboard: [w1]
Attached file pull request
This is the 1st pull request for the browser app on TV. The source is cloned and modified from the original browser app on v2.0 to gaia/tv_apps/browser. 

* Unused modules and style sheets are removed. 
* HTML structure is tailored according to TV UI spec.
Attachment #8507774 - Flags: review?(timdream)
Attachment #8507774 - Flags: review?(ehung)
Comment on attachment 8507774 [details] [review]
pull request

rubberstamping so this could land, since this entirely lives in tv_apps.
Attachment #8507774 - Flags: review?(timdream) → review+
Attachment #8507774 - Flags: review?(rexboy)
Comment on attachment 8507774 [details] [review]
pull request

Looks good to me with some nits. See comments on Github.

Thanks for the patch!
Attachment #8507774 - Flags: review?(rexboy) → review+
Comment on attachment 8507774 [details] [review]
pull request

r+ but didn't look into details. I believe Rex has already checked.
Attachment #8507774 - Flags: review?(ehung) → review+
Merged into master: https://github.com/mozilla-b2g/gaia/pull/25319

gaia-try: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=01a2d6d74f2c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1092904
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: