[Stingray] Scaffold the TV browser

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yifan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [w1])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
timdream
: review+
Evelyn Hung
: review+
rexboy
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Scaffold a TV browser app in gaia/tv_apps folder base on the original browser for v2.0.
(Reporter)

Updated

4 years ago
Blocks: 1074624
(Reporter)

Updated

4 years ago
Blocks: 1074617
(Reporter)

Updated

4 years ago
Blocks: 1074625
(Reporter)

Updated

4 years ago
Whiteboard: [w1]
(Reporter)

Comment 1

4 years ago
Created attachment 8507774 [details] [review]
pull request

This is the 1st pull request for the browser app on TV. The source is cloned and modified from the original browser app on v2.0 to gaia/tv_apps/browser. 

* Unused modules and style sheets are removed. 
* HTML structure is tailored according to TV UI spec.
Attachment #8507774 - Flags: review?(timdream)
Attachment #8507774 - Flags: review?(ehung)
Comment on attachment 8507774 [details] [review]
pull request

rubberstamping so this could land, since this entirely lives in tv_apps.
Attachment #8507774 - Flags: review?(timdream) → review+
(Reporter)

Updated

4 years ago
Attachment #8507774 - Flags: review?(rexboy)
Comment on attachment 8507774 [details] [review]
pull request

Looks good to me with some nits. See comments on Github.

Thanks for the patch!
Attachment #8507774 - Flags: review?(rexboy) → review+

Comment 4

4 years ago
Comment on attachment 8507774 [details] [review]
pull request

r+ but didn't look into details. I believe Rex has already checked.
Attachment #8507774 - Flags: review?(ehung) → review+
(Reporter)

Comment 5

4 years ago
Merged into master: https://github.com/mozilla-b2g/gaia/pull/25319

gaia-try: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=01a2d6d74f2c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Blocks: 1092904
You need to log in before you can comment on or make changes to this bug.