Closed Bug 107466 Opened 23 years ago Closed 22 years ago

message has wrong info in thread pane

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: endico, Assigned: cavin)

Details

(Whiteboard: [adt2 rtm],custrtm-)

Attachments

(2 files)

Email which exhibits "?]" popup behavior
44.73 KB, application/octet-stream
Details
Proposed patch, v1
2.87 KB, patch
naving
: review+
Bienvenu
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
This happens for me in daily builds from oct 25 and oct 29.
I am using imap.

I have two messages in my inbox from saturday afternoon that show up one
after the other when i sort by date. In the thread pane, the information
for the second message is printed in place of the correct information in
the first message so it looks like I have two of the second message. Viewing
the first message in the message pane displays the message correctly. 
Viewing the first message in its own window gives the wrong subject in the
title bar.  This wrong info also shows up in the search results window.

I have not moved either of these messages nor have I filtered them.

My mozilla.org mail is delivered to two places. The messages are only messed
up on my netscape account. My home acct uses a different IMAP server and the
messages display ok there.
i'm not sure whether this is related but in in the oct 29 build i am unable to
read the second message (whose header is repeated in the first message). When
I try to view the message I get a dialog that says "?]"  I also get this dialog
with a few other messages as well but the headers for those messages display
correctly.

The messages are viewable in my oct 25 build.
message is also displayed wrong with the 10/12 0.9.5 branch build.
Changing the summary. I orginally thought the problem happened because the 
messages had the same time stamp, but that's not true.
Summary: message sent at the same time as another has wrong info in thread pane → message has wrong info in thread pane
I'm encountering a similar if not the same problem in a news folder. This is
with a trunk debug build from 10/30 about 9am PST.

I'm going to attach a zip of my new folder should someone be able to reproduce
it. This occurs also with a 0.9.2 release build.

The two messages in question are.
1. Subject: Re: Avatar: Information heading through explicit template instantiation
   Author: Garry Lancaster
2. Subject: Re: Objects with thread-behavior
   Author: Rakesh Tiwari

I viewed these two messages one after another. Other than that they don't appear
to have anything in common. I don't know if the first message finished
displaying or not. So it could be a case where things were in mid progress when
I clicked next.
Actually mine is a bit different. The list of messages is fine. It's the message
window that has the wrong message. Search displays the proper subjects but when
I choose the message it displays the second.

Going to look for another bug, or file a new one of none exists.
I am using 2001-10-30-11 on linux. I am not able to reproduce this problem by 
any message. It could some thing specific the message or headers in that message 
that could be causing this problem.  I checked the news messages too by opening 
them in a stand alone window.  It should me the right message.

Dawn,
Are you still seeing this problem with all the messages that you have been 
getting using the netscape server.  
I'm able to reproduce this, Linux, cvs build date 2001/10/29+

Various messages (quite infrequent for me) won't be rendered.  Moz simply   
pops up a dialog with "?]" and does nothing more.

Sheela, were you able to reproduce this with the attached email?  Is anyone
still seeing this?
Status: NEW → ASSIGNED
I copied the attached message to a local folder. I was not able to reproduce the 
problem where the dlg comes up with a "?".  Tried to edit as new message and 
sent the message to my imap account. Still no problem.  Copying the message from 
local to imap inbox was not possible becuase I got an error saying the message 
had an invalid header. But still displayed the message fine and also other 
messages in that folder too. No problem when viewed with a stand alone window 
too. Worksforme.
build: 2002-01-18-06 linux
2002-01-22-06 win98
Keywords: nsbeta1
We have a reproducible case, this has been showing up more frequently within our
CPD (Montse, Evelyn, Gayatri, Esther have seen this).  This happens when the
user is viewing a forwarded message with an attachment, another message with an
attachment arrives in Inbox, immediately after it arrives and without scrolling
or any other action the user opens the attachment of the message being viewed. 
At this point after closing the app that launched the attachment, user selects
the message that came in.  Result: in the thread pane, the header of the message
that came in changes to the same header as the message that was being viewed. 
This must meet certain criteria that's why it's been so hard to narrow now, but
not uncommon.
here is what we did to reproduce on windows, you can substitue your own app and
file if you want:

1. Have Powerpoint .pps file handy so you can attach it to a mail message. (one
is attached to this bug)
2. Have Powerpoint installed and properly assigned so the attachment opens when
you click on it.
3. Send yourself that .pps file with 4.7x, get the message and then forward it
to yourself Inline.
4. Launch MachV (we used branch build dated 5-1-02).  Open mail and get the message.
5. While message is selected and displayed in message pane, from another system
send yourself an html page using send page.
6. Let biff bring in or do a Get Msg to retrieve the html message you just sent.
(make sure you don't do anything else but Get Msg, no scrolling etc.) As soon as
the message comes in, OPEN the attachment on the message being viewed. (note it
may not display at first, we think this is because something is going on with
the new message at the same time).  
7. Close the Power point app.
8. Select the newly arrived message.  
Result: the header for the newly arrive message changes to the header of the
message you were viewing when it came in.  When you click on it you will see the
body of the message that has the html page.  At this point your msf file is
corrupt and this condition will stay with the Inbox until the user removes the
.msf file.
file too big to attach, I will zip it later. In the meantime a message with this
attachment is located in 3qatest07 for those who can get to that test account.
Also note: when attachment fails the first time to display in PowerPoint,
immediately try again, it will display.  Then Close PowerPoint.
marking nsbeta1+ per mail triage.
Keywords: nsbeta1 → nsbeta1+
OS: Linux → All
Whiteboard: [adt2 rtm]
Whiteboard: [adt2 rtm] → [adt2 rtm],custrtm-
reassigning to cavin.
Assignee: sspitzer → cavin
Status: ASSIGNED → NEW
Using Esther's steps in comment #11, I was not able to reproduce the problem 
with both 05/28 branch and 06/03 trunk builds (I only have these two installed 
on my machine).

I was able to see the new msg header and the right html page (as the msg body 
text) after completing step (8) (ie, select the newly arrived message).

However, I did find a new problem after finishing step (6) (ie, open the 
PowerPoint attachment). The problem is that PowerPoint was launched but there's 
no data in the application at all, as PowerPoint asked me if I wanted to create 
a new one. After quitting PowerPoint I then opened the attachment the second 
time and it worked fine. It's only the first time that it failed.

I tried the exact same scenario with the Save attachment option (instead of  
open) and the saved .pps file was 0 byte in size! So both Save and Open have the 
same problem.

Ccing ducarroz in case he saw this problem before.
The imap log does indicate that the PowerPoint attachment data is indeed 
downloaded to the client, just that the data is not showing up in the local 
file.
Ccing David in case he knows a possible cause of it.
I worked with Cavin on this, we can reproduce this on his system with one of the
latest branch builds 20020528.  My mistake in step #3.  You need to forward as
attachment from 4.7.
The problem is that in nsImapProtocol::HandleMessageDownLoadLine() we make the 
following call:

  m_downloadLineCache.CacheLine(localMessageLine,
           GetServerStateParser().CurrentResponseUID());

to cache lines associated with the msg/attachment. Normally the second parameter 
(ie, GetServerStateParser().CurrentResponseUID()) of the call is the uid of the 
msg currently selected. But in case new mail arrives this uid will be reset to 
the newest mail msg's uid. So when this happens, if we click on the attachment 
of the currently selected msg (note that the msg selection has not been changed 
even after new mail arrives) the uid in the server state parser still points to 
the newly arrived msg's, which is wrong.

Because the uid stored in 'm_downloadLineCache' is wrong we're getting the 
subject, sender, date etc. info off the currently selected msg for the newly 
arrived msg in the thread pane list.

A patch is coming.
great job, Cavin!
In nsImapProtocol::ProcessSelectedStateURL(), before we call
'foundShell->Generate()' make sure the server state parser has the right msg
uid, because it may contain the uid of a new mail msg and not the currenly
selected msg.
Comment on attachment 86517 [details] [diff] [review]
Proposed patch, v1

sr=bienvenu,seems reasonable.
Attachment #86517 - Flags: superreview+
Comment on attachment 86517 [details] [diff] [review]
Proposed patch, v1

r=naving
Attachment #86517 - Flags: review+
Comment on attachment 86517 [details] [diff] [review]
Proposed patch, v1

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.
Attachment #86517 - Flags: approval+
Once this lands in the trunk, could you verify this esther?
Keywords: adt1.0.1
Fix checked into the trunk.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Esther, can you verify this on a trunk build?
I will check this on the trunk today 6-10.
Using trunk build 20020610 on winxp, the scenario is working OK, however with
the trunk build a downloading manager pops up too showing that file
foto200_1.pps is still downloading.  I don't see the downloading manager when I
use the branch build, so I'm not sure if this pop up manager is a side affect of
the fix or not.
No, downloading manager showing up is not caused by this fix.
OK, I tried the 6-10 branch build to see if displaying the download manager is
new to the product, it isn't in the branch build.  However, I did notice I get
the download manager when using the trunk build, just downloading the latest
build from sweetlou, without mail being involved. 
So I continued verifying this bug on the trunk build for linux and mac os10.1. 
All platforms ok.  Note: the original scenario stating "a dialog that says
"?]"", which both sheela and I have not seen when trying to reproduce this, it
may be a different bug.  The bug being verified is wrong message header dislayed
in thread pane.  Verified.
Status: RESOLVED → VERIFIED
Keywords: mozilla1.0.1
adt1.0.1+ (on ADT's behalf) approval to checkin to the 1.0 branch, pending
Drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.
thanks!
Keywords: adt1.0.1 → adt1.0.1+
Is this bug the same as http://bugzilla.mozilla.org/show_bug.cgi?id=58520 ?

The summaries don't sound the same, but some of the comments do...
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
I doubt it - I think that bug has more to do with blank entries getting in the
memory cache (though that has been fixed, I believe). However, some of the
people might have been seeing this bug (i.e., as often happens, there could be
several different bugs getting described in that bug). I do have several dups of
this bug, however.
Fix checked into the branch.
Keywords: mozilla1.0.1+ → fixed1.0.1
This is fixed per original scenario.  Note, the problem mentioned by Cavin in
comment #16  "However, I did find a new problem..." is still there.  Cavin was
this bug fix suppose to fix both the incorrect thread header and the .pps file
not launching the first time?  If so, do you want me to verify this one as fixed
and log a new bug for the outstanding issue you brough up in comment 16 or
reopen this?
> If so, do you want me to verify this one as fixed and log a new bug for the 
> outstanding issue you brough up in comment 16 or reopen this?
>
Please open a new bug against "not being able to download the .pps attachment
the first time" problem (ie, 2nd time works fine). Thanks.
Verified on branch 20020614 on winxp, and opening a new bug for other issue.
Keywords: fixed1.0.1 → verified1.0.1
new bug logged for outstanding issue 152421
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: