Closed Bug 1074678 Opened 5 years ago Closed 5 years ago

As a user, I should be able to click on a room and have the room open

Categories

(Hello (Loop) :: Client, enhancement, P1)

enhancement
Points:
3

Tracking

(firefox35 verified, firefox36 verified)

VERIFIED FIXED
mozilla36
Iteration:
36.2
Tracking Status
firefox35 --- verified
firefox36 --- verified
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

(Whiteboard: [rooms])

User Story

* As a user, I should be able to click on a room and have the room open, so that I can preview myself and be ready for when someone joins

UX:
* Clicking anywhere on the room list item view, apart from the copy and delete buttons should open the conversation view

Implementation:
* Send a message via mozLoop API to the service to open a conversation window with the appropriate room information.

Attachments

(1 file, 2 obsolete files)

No description provided.
User Story: (updated)
Blocks: 1074671
Severity: normal → enhancement
backlog: --- → Fx35+
Priority: -- → P1
Assignee: nobody → standard8
Iteration: --- → 36.2
Points: --- → 3
Depends on: 1090209
Depends on bug 1090209. This completes the flow and gets the right data to the right places.

NiKo: How do you think we should handle the openRoom - with an action to the store (which has mozLoop available for mocking), or similar to what I've got in this patch, called direct.
Attachment #8514366 - Flags: feedback?(nperriault)
Comment on attachment 8514366 [details] [diff] [review]
Open a room window when the user selects the room in the Loop panel.

Review of attachment 8514366 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

(In reply to Mark Banner (:standard8) from comment #1)

> NiKo: How do you think we should handle the openRoom - with an action to the
> store (which has mozLoop available for mocking), or similar to what I've got
> in this patch, called direct.

I'd find it more consistent to dispatch an action, so anything mozLoop.rooms calls would be performed from stores; having everything using some particular API localized in a single place is usually helpful when debugging, and improves maintainability over time imoe.

::: browser/components/loop/MozLoopAPI.jsm
@@ +111,5 @@
> +        });
> +      }
> +      else {
> +        api[func](...params, lastParam);
> +      }

Nit: This dense section would benefit from a bit more commenting I think.
Attachment #8514366 - Flags: feedback?(nperriault) → feedback+
Updated patch, for bug 1090209 changes. This depends on that bug - though I've also not had chance to update for bitrot since NiKo's create room patch landed.
Attachment #8514366 - Attachment is obsolete: true
Attachment #8515091 - Flags: review?(mdeboer)
Comment on attachment 8515091 [details] [diff] [review]
Open a room window when the user selects the room in the Loop panel.

Review of attachment 8515091 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one comment addressed. <3 the cleanup.

::: browser/components/loop/test/xpcshell/test_looprooms.js
@@ +178,5 @@
> +  };
> +
> +  LoopRooms.open("fakeToken");
> +
> +  do_check_true(!!openedUrl, "should open a chat window");

Assert.ok(openedUrl, "...");
Attachment #8515091 - Flags: review?(mdeboer) → review+
Updated for review comment and bitrot.
Attachment #8515091 - Attachment is obsolete: true
Attachment #8515958 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/24d86d8ed318
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/24d86d8ed318
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Flags: qe-verify+
Flags: in-moztrap?
Comment on attachment 8515958 [details] [diff] [review]
Open a room window when the user selects the room in the Loop panel.

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8515958 - Flags: approval-mozilla-aurora?
Attachment #8515958 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
> UX:
> * Clicking anywhere on the room list item view, apart from the copy and delete buttons should open the > conversation view
Actually, clicking only on the call URL opens the conversation window.
Verified fixed FF 35b4, 36.0a2 (2014-12-17) Ubuntu 13.04
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.