107474 - File::Basename->basename broken on Windows

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Gervase Markham [:gerv]]

The above-named function returns the string "basename" on Windows. This makes it
pretty useless for determining a file's basename.

(Also, some of the paths being generated in chromelist.txt are ugly and need
canonicalising.)

Upcoming patch fixes both problems; thanks to hewitt for providing it.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 55669 [details] [diff] [review]
Patch v.1

r=cls wfm (dunno why it works but it works)

Comment 3

[hacker formerly known as [e-mail]]

Patch checked in.

Comment 4

[Gervase Markham [:gerv]]

Thanks, Chris. I meant to do this last night but alecf was fanning the flames of
the tree :-)

Gerv

Comment 5

[Tracy Walker [:tracy]]

verified