1074777 - If Loop server crashes, when trying to signing-up, we should inform the user about this fault.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

STR:
1. Launch Loop application 
2. Finish the wizard and go to Log-in screen
3. Connection with the Loop server is lost (Loop server crash)
4. Try to log-in in Loop via FxA or Mobile ID

Current Result:
User can not log-in but not message error is shown

Expected Result:
We should inform about the Loop server crash or fail.

Comment 1

[Maria Angeles Oteo (:oteo)]

Pau, Monica, can you help us with the string in this message? Thanks a lot!

Comment 2

[Mónica UX/UI]

Attachment: Wireframe+Strings_1074777

Attached the PDF with the Wireframe+Strings.
It is possible that in a Server Failure I add a "Retry" button. (I'm waiting Rafa's confirmation)

Comment 3

[Maria Angeles Oteo (:oteo)]

(In reply to Mónica UX/UI from comment #2)

> It is possible that in a Server Failure I add a "Retry" button. (I'm waiting
> Rafa's confirmation)

Thanks Monica, anyway and due to time constraints we already agreed that the "Retry" button is a nice to have. So, not necessary to implement for this 1.1 version.

Comment 4

[Pau Masiá [:Pau]]

Looks good.

Comment 5

[Maria Angeles Oteo (:oteo)]

Updated the title because it was not correct, we need to prompt the user when he tries to SIGN-UP in Loop application and the server is down.

Once he has already signed-up, if the server is down or there is not data connection he will be offline signed-in (bug 1074271).

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Monica, we already have a string for generic server failures which is [1]. Could we reuse that string instead of adding the new one you added in the UX proposal? Please, let us know. Thanks!

[1] https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/locales/loop.en-US.properties#L110

Comment 8

[Mónica UX/UI]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #7)
> Comment on attachment 8501736 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169
> 
> Monica, we already have a string for generic server failures which is [1].
> Could we reuse that string instead of adding the new one you added in the UX
> proposal? Please, let us know. Thanks!
> 
> [1]
> https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/locales/
> loop.en-US.properties#L110

Ahh, ok! That string [1] it's ok! I didn't know there was a string for it.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Thanks jaoo! I left you a few comments on the PR

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Thanks for the previous review, would you mind to have a look again please? Thanks!

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

You missed a few comments from the previous review :)

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Almost there :)

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8501736 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/169

Thanks!

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ccbf32749ab07f70240b082b799f8c0bc6545cdc