Closed
Bug 1074854
Opened 10 years ago
Closed 10 years ago
properly store proxy pointers in AtkObject::AccWrap
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(1 file)
1.03 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
We need to make sure if accWrap points at a proxy not an accessible the stored value needs to include IS_PROXY.
Assignee | ||
Comment 1•10 years ago
|
||
When the accWrap field points at a proxy its value must be the pointer or'd with IS_PROXY, but we incorrectly stored the plain pointer.
Attachment #8497516 -
Flags: review?(dbolter)
Comment 2•10 years ago
|
||
Comment on attachment 8497516 [details] [diff] [review] properly mark proxies in atkobject::accWrap Review of attachment 8497516 [details] [diff] [review]: ----------------------------------------------------------------- (I'm still unsure of the memory vs reinterpret_cast tradeoff)
Attachment #8497516 -
Flags: review?(dbolter) → review+
Comment 3•10 years ago
|
||
backed this out in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=49b06fb31f0b together with the other landings from that push (and bug 1074917 which caused conflicts during backout) for the regression mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=982842#c41
https://hg.mozilla.org/mozilla-central/rev/a322cd5986b0
Assignee: nobody → tbsaunde+mozbugs
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•