Closed Bug 1074896 Opened 5 years ago Closed 5 years ago

Include a "donate" link in the About Firefox dialog

Categories

(Firefox :: Menus, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: mhoye, Assigned: mhoye)

Details

Attachments

(2 files, 2 obsolete files)

Attached image Donation_link.jpeg
The text of the About Firefox page includes a link to the "get involved" page, but not a "donate" link. We should add the option there of to make a donation. Something that looks like the attached.

Patch forthcoming, momentarily.
Why does https://www.mozilla.org/en-US/contribute/ not include the option to donate?
I have an excellent answer to that question that the scope of this bug is too small to contain.
Adds a direct "donate" link to About Firefox. Link comes from Geoffrey's team.

Will be CC'ing GMC at M's suggestion.
Attachment #8497602 - Flags: ui-review?(madhava)
Attachment #8497602 - Flags: review?(gavin.sharp)
cc'ing the C.
Dao - I've since learned that in mid October, that page's redesign will include donate link. I'd still like to include a link in-client, though.
Comment on attachment 8497602 [details] [diff] [review]
add_donation_link_to_about_firefox_menu.patch

First the technical feedback:

For various not great reasons, every time you need to change a string in Firefox, you need to also change its name, so that the semantic change is visible to localizers.

So contribute.start and contribute.getInvolvedLink need to change names. To remain consistent, we might as well change all the contribute.* strings. Perhaps just change them to "helpus.*".
Attachment #8497602 - Flags: ui-review?(madhava)
Attachment #8497602 - Flags: review?(gavin.sharp)
Attachment #8497602 - Flags: review-
Second, feedback on the idea itself:

Soliciting donations has to be done in context, and I'm not sure this is the best context - but it's probably the best place in Firefox proper (given the message surrounding it and relative unobtrusiveness).

The proposed user flow still is a bit confusing: user is using Firefox, opens the about dialog and reads about our "global community", is asked to donate (to whom? the community?), clicks the link, ends up at the sendto page that mentions "Donate to Mozilla", has a general mission statement and second mention of the community, and vague easy-to-miss description of what the money is used for (charitable purposes). Is this donation related to their use of Firefox? Is it supporting development of Firefox, or something else?

I don't expect you to necessarily have answers to this concern, but I thought I'd raise it. Not a deal killer - I assume the intent is to support Foundation fundraising goals, but note that due to l10n restrictions, we can't really release this fully-localized before Firefox 36, which is out at the end of February.
Thanks for the feedback, I'll correct and resubmit.
Resubmitting with the changes mentioned. I agree that the proposed interaction flow isn't perfect, but the link gives us a measurable result to experiment against once it's in.
Attachment #8497602 - Attachment is obsolete: true
Attachment #8505011 - Flags: review?(gavin.sharp)
Comment on attachment 8505011 [details] [diff] [review]
bug_1074896_add_a_donate_link_to_about_dialog.patch

>diff --git a/browser/base/content/aboutDialog.xul b/browser/base/content/aboutDialog.xul

>-          <description class="text-blurb" id="contributeDesc">
>+          <description class="text-blurb" id="helpusDesc">

No need to change this ID - doing so breaks the aria-describedby reference earlier in the file.

r=me with that change undone.
Attachment #8505011 - Flags: review?(gavin.sharp) → review+
Attachment #8505011 - Attachment is obsolete: true
Attachment #8505506 - Flags: review?(gavin.sharp)
Comment on attachment 8505506 [details] [diff] [review]
bug_1074896_add_a_donate_link_to_about_dialog-v2.patch

There's generally no need to re-request review on an r+ed patch if the only change you made was the one requested - though of course you're welcome to if there's something you want double-checked.

One thing I realized only now, looking at it again: the start/middle/end strings give localizers some required flexibility in wording, but it does forces the ordering of the "Make a donation" and "get involved!" links (one before the other). Hopefully that is not problematic for any of our supported languages.
Attachment #8505506 - Flags: review?(gavin.sharp) → review+
OK, thanks. Off we go.
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Summary: Include a "donate" link in the About Firefox menu. → Include a "donate" link in the About Firefox dialog
https://hg.mozilla.org/integration/fx-team/rev/20a0ffce7bee - but not landed on m-c yet :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
On m-c now...

http://hg.mozilla.org/mozilla-central/rev/20a0ffce7bee
Assignee: nobody → mhoye
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Woot!
You need to log in before you can comment on or make changes to this bug.