1074903 - [Browser Start Page] No title shown for top site

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Eric Pang [:epang] UX]

Attachment: 2014-09-30-17-04-12.png

The black banner and title is not always shown for all screens.
In the attached example it's missing from the first screen.

Comment 1

[Eric Pang [:epang] UX]

Hey Dale, I'm guessing this is because a title in not available?  I think in this case we should show a url, looks odd with nothing there.  Francis, what do you think?

Comment 2

[Dale Harvey (:daleharvey)]

Its feasible that we dont have a title, I thought it was covered but will check and fix if not

Comment 3

[Francis Djabri [:djabber]]

(In reply to Eric Pang [:epang] from comment #1)
> Hey Dale, I'm guessing this is because a title in not available?  I think in
> this case we should show a url, looks odd with nothing there.  Francis, what
> do you think?

Agreed, that sounds like a good idea.

Comment 4

[Kevin Grandon :kgrandon]

Dale - I assumed that you wanted to assign this to yourself instead of being the qa contact? :)

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/daleharvey/gaia/commit/f8a08ea9541df4b15aeda7282352174c97b00ec4

Heh cheers for fixing assignment, based this on top of https://bugzilla.mozilla.org/show_bug.cgi?id=1071057 as I needed it for testing

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8498387 [details]
https://github.com/daleharvey/gaia/commit/f8a08ea9541df4b15aeda7282352174c97b00ec4

Thanks for the test. I left one comment on github.

Comment 7

[Dale Harvey (:daleharvey)]

Switched the test to an async, cheers

https://github.com/mozilla-b2g/gaia/commit/d711d1e469eeeecf25a02b2407a542a598918b2c