1074931 - bugzilla cc autocomplete is too aggressive

Status: RESOLVED INVALID

(Bugzilla :: User Interface, defect)

Description

[andy]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140918134209

Steps to reproduce:

I went to this bug report:

https://bugzilla.mozilla.org/show_bug.cgi?id=1073224

I clicked the "Add" box in the "CC List".  I typed "[e-mail]".  I did *not* accept any autocompletes.  I clicked "Save Changes".


Actual results:

[e-mail] was CCed.


Expected results:

Either [e-mail] should have been CCed or I should have received an error.

To double-check the UI is indeed broken, I tried again very carefully.  I typed "[e-mail]" and I clicked outside dropdown to dismiss it.  Then I saved changes again.  No dice: it still thought I wanted to CC john.hawksley.

Then I typed an actual name followed by "([e-mail])" and tried to save.  That finally resulted in an error (specifically that [e-mail] is not known to Bugzilla).

All three of my attempts should have resulted in that error, and [e-mail] should not have been CCed.

Comment 1

[Ryan Kelly [:rfkelly]]

Re-categorizing closer to the folks who can do something about this

Comment 2

[Frédéric Buclin]

Autocompletion is great, and typing partial email addresses is very common. If admins don't like that, then they can enable the confirmuniqueusermatch parameter.

Comment 3

[andy]

I'm fine with typing partial email addresses, if those partial addresses are prefixes of the full address (this wasn't) and if *clicking outside the autocomplete box to dismiss it* didn't silently autocomplete anyway.

Look at Firefox's in-browser autocomplete for an example of a perfectly fine autocomplete mechanism.

Comment 4

[Mark Côté [:mcote]]

I agree.  I don't consider it autocomplete if it doesn't update the actual input box but silently decides to use it--that's autoguess.  You should have to explicitly choose the suggestion.

Comment 5

[Frédéric Buclin]

(In reply to Mark Côté [:mcote] from comment #4)
> You should have to explicitly choose the suggestion.

As I said in comment 2, there is a parameter for that. On BMO, this param is off. No need for extra code.

Comment 6

[Mark Côté [:mcote]]

Ah true, it's enabled on the local BMO dev box, but not on BMO.  dkl, is there some particular reason it's disabled on BMO?

Comment 7

[Mark Côté [:mcote]]

Sorry, didn't mean to reopen that.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Wouldn't turning it on break being able to CC mcote by entering ":mcote" and pressing enter? I don't think that's a good idea.

Comment 9

[Mark Côté [:mcote]]

Yeah it would.  (Well, it would take you to a confirmation screen, requiring another click).  I didn't realize people actually did that. :) I don't think we can have it both ways, then...

Comment 10

[andy]

Sounds like there should be an intermediate option in which pressing enter selects the top autocomplete suggestion and in which there's no prompt in the contents of the text box actually match a full email address.

Comment 11

[David Lawrence [:dkl]]

(In reply to Mark Côté [:mcote] from comment #6)
> Ah true, it's enabled on the local BMO dev box, but not on BMO.  dkl, is
> there some particular reason it's disabled on BMO?

No reason that I am aware of. I have not twiddled that from what I can remember since joining. It is probably 'on' on the BMO test box as that is the default value and we create the test box with all default settings (maybe we should change that).

dlkl