1074944 - Add Inverse() functions to Moz2D Matrix classes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Not having a Inverse() function means that we have use Invert() everywhere which doesn't chain properly, and leads to much more annoying code.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Add the Inverse() functions

This is a little stricter than what most code does now, which is just call Invert() and ignore the return value.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Update some call sites

r? to nical since he reviewed the conversion from gfx3DMatrix -> Matrix4x4

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try push at https://tbpl.mozilla.org/?tree=Try&rev=697708407a34 includes these two patches

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Add the Inverse() functions

Forgot to qref the #include. New try push: https://tbpl.mozilla.org/?tree=Try&rev=f9de5ed9f8d9

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 8497632 [details] [diff] [review]
Part 1 - Add the Inverse() functions

Review of attachment 8497632 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, I'm not sure I agree with this. If we do go this way I'm inclined to say we should check the bool even in release builds and MOZ_CRASH when it fails. It's very dangerous from a 'potential security bug' perspective to accidentally poison our pipeline with NaN values.

Comment 6

[Bas Schouten (:bas.schouten)]

Comment on attachment 8497632 [details] [diff] [review]
Part 1 - Add the Inverse() functions

Review of attachment 8497632 [details] [diff] [review]:
-----------------------------------------------------------------

I guess the original code doesn't force people to check the return value either (although they should!) and I suppose we just do a no-op when the Matrix is !invertible, so I suppose this doesn't make things any worse.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f68b63f42f3e
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8b326379790

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f68b63f42f3e
https://hg.mozilla.org/mozilla-central/rev/a8b326379790