1074954 - [buddyup] API to mark answers as helpful

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[Michael Cooper [:mythmon]]

We already have helpful voting (or something like that) on answers. This should be exposed with an API.

Comment 1

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/kitsune/pull/2248

This is/was easy. Marking it as 1pt.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.

https://github.com/mozilla/kitsune/commit/2d73eb49fdf9c343b5ddf0e138023230fd58f0b0

Comment 3

[Schalk Neethling [:espressive]]

Trying to understand how to use the API for this and from looking at the code here:
https://github.com/mozilla/kitsune/pull/2248/files#diff-2f61d5b1d7fa186f1558973853d275d4R197

it seems that this should work much in the same vein as set_metadata so, I construct a URL such as:
https://support.allizom.org/api/2/answer/600270/helpful/?format=json

also tried:
https://support.allizom.org/api/2/answer/helpful/600270/?format=json

I do send a payload currently, although this is probably not needed, of:
{"num_helpful_votes":1}

and I do make the request whilst passing the token.

At the moment I am getting a 404 when hitting the above.

Comment 4

[Schalk Neethling [:espressive]]

FYI, also tried this one:
https://support.allizom.org/api/2/answer/600270/helpful?format=json

With all of that, I am also noticing that this seems to be related to questions? looking at the import of QuestionVote. If so, do we have an API to mark a comment/answer as helpful? Currently there is no user story or requirement to mark a question as helpful.

Comment 5

[Michael Cooper [:mythmon]]

You're right. This is for Questions, not Answers. Re-opening to fix that.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Deployed fix to prod now:
https://github.com/mozilla/kitsune/commit/1ad6d08cca32fa1f61a2b6510b2edcf965836fd3

Comment 7

[Schalk Neethling [:espressive]]

This service currently responds with what seems to be an empty string. Should it not respond with the new helpfulness count?

Comment 8

[Michael Cooper [:mythmon]]

That seems like a sane and useful thing for it to return. I filed bug 1118033 for that.