Closed Bug 1074969 Opened 7 years ago Closed 7 years ago

missing extended attributes when serving balrog release builds

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

I found this while doing snippet comparisons:
* Missing a lot of extended attributes:
FAIL: Unmatched snippets on /update/3/Firefox/10.0.1/20120208060813/Darwin_x86_64-gcc3-u-i386-x86_64/de/release/Darwin%2010/default/default/update.xml?force=1:
--- https://aus3.mozilla.org//update/3/Firefox/10.0.1/20120208060813/Darwin_x86_64-gcc3-u-i386-x86_64/de/release/Darwin%2010/default/default/update.xml?force=1
+++ https://aus4.mozilla.org//update/3/Firefox/10.0.1/20120208060813/Darwin_x86_64-gcc3-u-i386-x86_64/de/release/Darwin%2010/default/default/update.xml?force=1
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <updates>
-    <update type="minor" displayVersion="32.0.3" appVersion="32.0.3" platformVersion="32.0.3" buildID="20140923175406" detailsURL="https://www.mozilla.com/de/firefox/32.0.3/releasenotes/" actions="showURL" openURL="https://www.mozilla.org/de/firefox/32.0.3/whatsnew/?oldversion=%OLD_VERSION%">
+    <update type="minor" displayVersion="32.0.3" appVersion="32.0.3" platformVersion="32.0.3" buildID="20140923175406" detailsURL="https://www.mozilla.com/de/firefox/32.0.3/releasenotes/">
         <patch type="complete" URL="http://download.mozilla.org/?product=firefox-32.0.3-complete&amp;os=osx&amp;lang=de&amp;force=1" hashFunction="sha512" hashValue="b35081c3fd4d9ef8817f0a2ad6fe0d66fde87cebd8c1eaa53bbd3b2af443d20a9ad75f55827cee1092ecc67b6cc732b779ee2e1416cd2adc03650dd9d8239865" size="63415956"/>
     </update>
 </updates>
---- end of diff

We're missing actions and openURL. I'm guessing that we need to update the balrog submitter to add these.
I'm going to be patching the balrog submitter for bug 1021026, I'll probably do this at the same time to save on testing time.
Assignee: nobody → bhearsum
I tested this with this blob: https://aus4-admin-dev.allizom.org/releases/Firefox-33.0-build1/data and this URL: https://aus4-dev.allizom.org/update/3/Firefox/33.0/20141002185629/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/default/default/default/update.xml

It doesn't help us if we need to set this for nightly style updates, but that can be added easily later.
Attachment #8502629 - Flags: review?(nthomas)
Comment on attachment 8502629 [details] [diff] [review]
support openURL in blob creator

Looks good.
Attachment #8502629 - Flags: review?(nthomas) → review+
Attachment #8502629 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.