1074974 - Make HelpersD2D.h's CreateStrokeStyleForOptions more robust

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

I'm seeing Windows 7/8 failure of layout/reftests/svg/stroke-dasharray-01.svg with some of my patches. It turns out this is because if you pass a StrokeOptions argument to HelpersD2D.h's CreateStrokeStyleForOptions function where the object has mDashLength set to zero, then CreateStrokeStyleForOptions will still try to go ahead and create a dash pattern if mDashPattern is set. This results in the stroke failing to paint.

Perhaps CreateStrokeStyleForOptions should check mDashLength in addition to checking whether mDashPattern is null. If that's not acceptable, than at the very least it should assert.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8497623 [details] [diff] [review]
patch

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/54fe4cbba069

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54fe4cbba069