1074993 - (app-grouping) Make group headers match updated spec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

Currently the hit targets for the group header and font-sizes conform to an older version of the spec. We should update them to match the new one.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Update group headers to match spec

Based on bug 1074798, so that needs to be reviewed/merged before reviewing this.

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8497649 [details] [review]
Update group headers to match spec

A review from either of you would be great

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8497649 [details] [review]
Update group headers to match spec

Please once bug 1074798 is in master ask me for a review. thanks a lot

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8497649 [details] [review]
Update group headers to match spec

I'm assuming this is for the single commit here: https://github.com/Cwiiis/gaia/commit/02ae23ac18ae492bff1c1d9e646d298c04ef5829

The main reason I can't R+ this is that the @2.0x.png images are named wrongly. These should be @2x instead. Fix that and R+.

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8497649 [details] [review]
Update group headers to match spec

Fixed 2x image naming, assuming r+.

Comment 6

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/08ecd85443b56211d65f60eb094242cf5f87ca96