107504 - Fizzilla's splash screen status line has the wrong appearance

Status: VERIFIED INVALID

(SeaMonkey :: UI Design, defect, P4)

Description

[adrian bellomo]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.5) Gecko/20011015
BuildID:    2001102910

there is a white box around 'starting up' on the mozilla splash screen

Reproducible: Always
Steps to Reproduce:
start mozilla

Actual Results:  there is a box around 'starting up'

Expected Results:  it should be all white on black.

Comment 1

[Greg K.]

Adrian, can you still reproduce this problem under 0.9.6?

Comment 2

[Greg K.]

Reporter, I think this is the intended display of the status line on the splash screen for Fizzilla. I'll 
have to defer to someone at Mozilla for verification on that, though.

I don't believe User Interface Design is the right component for this, but I'm not sure where the 
splash screen falls. Changing to Browser-General for now, and revising Summary.

Comment 3

[adrian bellomo]

Yes, this bug still occurs under 0.9.6+. And I don't think that this is 
expected behavior. I know that Mozilla under Mac OS 9 and Mozilla for 
Windows do not show this, and I doubt that Fizzilla is meant to do this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

xp apps:gui.  ccing pinkerton

Comment 5

[Mike Pinkerton (not reading bugmail)]

simon played with this for a few hours before and couldn't find a way to specify
a bg color and fg text color on the text item through resources. The ns builds
have the same problem. My guess is that the dialog manager under aqua just
doesn't support doing this.

don't see a fix anytime soon. recommend future. simon?

Comment 6

[adrian bellomo]

I think that this might be a bug in OS X... There are still plenty of them.

Comment 7

[Simon Fraser [no longer active]]

I think we need to use some Appearance foo in the dialog resources and/or the 
code. I'll play with it.

Comment 8

[Simon Fraser [no longer active]]

Attachment: nsNativeAppSupportMac patch for better progress text drawing

Patch for better progress text drawing. This now uses DrawThemeTextBox on X,
and TETextBox on 9, and sets the fore- and background colors correctly. I
change the dialog item in the resource file to a user item, rather than a
static text item, so we get no drawing by default to mess up. However, 'dftb'
settings for font and alignment no longer work for user items, so I've had to
add 'rgb ' resources for text color, and always draw flush left.

Comment 9

[Simon Fraser [no longer active]]

Note that you'll need some resource file changes to make this work. I'm too lazy
to encode them for attachment here.

Comment 10

[adrian bellomo]

Just for my reference, how do you apply a patch? I couldn't seem to find 
out how. Thanks.

Comment 11

[Simon Fraser [no longer active]]

Get MacCVS Pro, and use its 'Patch...' menu item. Or run 'patch' on the command 
line.

Comment 12

[Mike Pinkerton (not reading bugmail)]

+  nsAutoString    initialString; initialString.AssignWithConversion("Starting
up...");
+  DrawSplashScreenString(initialString.get());

can't this just use NS_LITERAL_STRING instead of creating an nsAutoString?

+    NS_ASSERTION(GetHandleSize(resHandle) == sizeof(RGBColor), "Bad color
resource");
+    mTextForegroundColor = *(RGBColor*)*resHandle;

so we assert, but go ahead and use it anyway? wouldn't we prefer the default
black and white if we know we have garbage colors?

these are nits, though. looks good otherwise. r=pink.

Comment 13

[Andy Lyttle]

*** Bug 142466 has been marked as a duplicate of this bug. ***

Comment 14

[Frankie]

Sorry for the spam. Fizzilla CFM build is dead; should this bug go with it?

Comment 15

[Simon Fraser [no longer active]]

->conrad

Comment 16

[Conrad Carlen (not reading bugmail)]

Invalid, since there is no splash screen in Mach-O build. For that, see bug
112559. The status line made by the patch on that bug is lovely.

Comment 17

[sairuh (rarely reading bugmail)]

v