Closed Bug 1075093 Opened 7 years ago Closed 7 years ago

Build error in txStylesheet.cpp when enabling PR_LOGGING in non-debug builds

Categories

(Core :: XSLT, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

When PR_LOGGING is defined but DEBUG is not we get the following build error on linux:

> /builds/slave/try-l64-0000000000000000000000/build/dom/xslt/xslt/txStylesheet.cpp:132:16: error: variable 'match' set but not used [-Werror=unused-but-set-variable]

This is due to TX_TO_STRING [1] only being defined for debug builds.

[1] http://hg.mozilla.org/mozilla-central/annotate/7c24470b6b3a/dom/xslt/xslt/txStylesheet.cpp#l169
Blocks: 806819
Nathan, it looks like you were the last person to review this file. Feel free to punt to someone else if you can find a better fit.
Attachment #8497708 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8497708 [details] [diff] [review]
Build error in txStylesheet.cpp when enabling PR_LOGGING in non-debug builds

Review of attachment 8497708 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Attachment #8497708 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/e3b4b545dace
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.