1075093 - Build error in txStylesheet.cpp when enabling PR_LOGGING in non-debug builds

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Eric Rahm [:erahm]]

When PR_LOGGING is defined but DEBUG is not we get the following build error on linux:

> /builds/slave/try-l64-0000000000000000000000/build/dom/xslt/xslt/txStylesheet.cpp:132:16: error: variable 'match' set but not used [-Werror=unused-but-set-variable]

This is due to TX_TO_STRING [1] only being defined for debug builds.

[1] http://hg.mozilla.org/mozilla-central/annotate/7c24470b6b3a/dom/xslt/xslt/txStylesheet.cpp#l169

Comment 1

[Eric Rahm [:erahm]]

Attachment: Build error in txStylesheet.cpp when enabling PR_LOGGING in non-debug builds

Nathan, it looks like you were the last person to review this file. Feel free to punt to someone else if you can find a better fit.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8497708 [details] [diff] [review]
Build error in txStylesheet.cpp when enabling PR_LOGGING in non-debug builds

Review of attachment 8497708 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.

Comment 3

[Eric Rahm [:erahm]]

try: https://tbpl.mozilla.org/?tree=Try&rev=3e763ae484af

Comment 4

[Eric Rahm [:erahm]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e3b4b545dace

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3b4b545dace