Closed Bug 1075100 Opened 7 years ago Closed 4 years ago

Grant contact permissions to all URLs served through the test agent

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review
In bug 1043562, I'm restricting the mozContacts API to contexts that have the appropriate permissions.  With that patch, navigator.mozContacts won't be available unless you have this permissions.  This means that the code that uses the test-agent won't have access to this API any more.

As a mitigation, I have a patch that hooks into the protocol handler for the app:// URLs we generate from the test-agent extension, to automatically grant the contacts permission to these URLs.
Assignee: nobody → ehsan.akhgari
Attached file Patch (v1)
Attachment #8497716 - Flags: review?(ricky060709)
Comment on attachment 8497716 [details] [review]
Patch (v1)

Hi, 

Although the patch seems very simple, I think I'm not familiar enough to review the httpd extension. Maybe Julien could help us review this patch.
Attachment #8497716 - Flags: review?(ricky060709) → review?(felash)
Comment on attachment 8497716 [details] [review]
Patch (v1)

Doesn't fix the issue in B2G (haven't tried in Firefox)

If we can't find a solution working in both, I think we can still land this if this works in Firefox only, because this will help use cases like running Gaia in Firefox.
Attachment #8497716 - Flags: review?(felash)
I tested this locally on Firefox Desktop, but I'm actually not 100% sure if I did everything right...  Will try to find some time this weekend to see if I can debug this.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.