1075100 - Grant contact permissions to all URLs served through the test agent

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[(no longer active)]

In bug 1043562, I'm restricting the mozContacts API to contexts that have the appropriate permissions.  With that patch, navigator.mozContacts won't be available unless you have this permissions.  This means that the code that uses the test-agent won't have access to this API any more.

As a mitigation, I have a patch that hooks into the protocol handler for the app:// URLs we generate from the test-agent extension, to automatically grant the contacts permission to these URLs.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8497716 [details] [review]
Patch (v1)

Hi, 

Although the patch seems very simple, I think I'm not familiar enough to review the httpd extension. Maybe Julien could help us review this patch.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8497716 [details] [review]
Patch (v1)

Doesn't fix the issue in B2G (haven't tried in Firefox)

If we can't find a solution working in both, I think we can still land this if this works in Firefox only, because this will help use cases like running Gaia in Firefox.

Comment 4

[(no longer active)]

I tested this locally on Firefox Desktop, but I'm actually not 100% sure if I did everything right...  Will try to find some time this weekend to see if I can debug this.

Comment 5

[BMO Automation]

Firefox OS is not being worked on