1075237 - Button appears as hanzi instead of icon

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, defect, P4)

Description

[Shu-yu Guo [:shu]]

Attachment: button.png

Something's not loading right, I suppose.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I've seen this occasionally, too. Sometimes the "pin" button next to suggested failure bugs will do similar things. Maybe a caching issue?

Comment 2

[Jonathan French (:jfrench)]

I too saw this, after some recent bootstrap updates. If I remember correctly I cleared my cache and reloaded, and I haven't seen it since. If it's reproducible after that though, let us know.

Comment 3

[Ed Morley [:emorley]]

Are we still seeing this?

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I haven't.

Comment 5

[Jonathan French (:jfrench)]

Attachment: nightlyClearedCache-OSX10.10.3

I see something kind-of similar but only on Firefox with an empty cache on page load. The attached example is the font-awesome icon for the Treeherder nav menu. I had to be very quick to screen grab it, subjectively visible for perhaps 1/10th of a second.

I have not seen anything persistent.

Comment 6

[Jonathan French (:jfrench)]

Yeah, I actually see the same fleeting draw on the originally reported resultset Cancel Job icon, in the same scenario above.

Comment 7

[Ed Morley [:emorley]]

I can repro comment 5 after clearing the cache or using devtools disable cache feature. However it never persists beyond the first N milliseconds, which is what the original bug seemed to be about. 

As for the initial flash on pageload, I think this may be working as intended. The icon comes from Font Awesome, and so needs the font file to have been fetched to display, which probably shouldn't block pageload. I guess the only behaviour that could be changed is making the icon not appear at all until the font has loaded, however that may also be confusing in the case where the font fails to load at all or is loading slowly.

Since this bug was filed we switched from a Grunt build pipeline to webpack, with improved asset hashing and long expiry cache headers, which (a) seems to have fixed the persistent broken icons in comment 0, (b) reduces the times when the empty cache initial flicker is hit.

As such, I think we can close this out :-)