[settings] remove security_privacy.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eragonj, Assigned: eragonj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Checking from codebase, it seems that there are duplicated functions between security_privacy.js and screen_lock_item.js, so I think it would be better to remove it and extract some other functions to a new file called  sim_security_item.js.
Created attachment 8497985 [details] [review]
patch on master

Arthur, recently there are some duplicated functions in `security_privacy.js` and I think it would be a nice timing to directly remove it from root.js and make it AMD.

Please help me review this patch when you have time.

Thanks !
Attachment #8497985 - Flags: review?(arthur.chen)
Comment on attachment 8497985 [details] [review]
patch on master

Sorry for the late review. The patch looks good to me and there are only a few comments to be addressed. And please also add jsdoc and unit tests, thanks!
Attachment #8497985 - Flags: review?(arthur.chen)
Thanks Arthur, I would add them back when the patch is good enough without any further change.
Comment on attachment 8497985 [details] [review]
patch on master

Arthur,

tests are added (I want to make sure code is ok before making tests) and all comments are addressed.

Please help me review again when you have time, thanks !
Attachment #8497985 - Flags: review?(arthur.chen)
Comment on attachment 8497985 [details] [review]
patch on master

r=me with the comment addressed and jsdoc added, thanks!
Attachment #8497985 - Flags: review?(arthur.chen) → review+
Thanks Arthur, this patch was merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/7afdc83937dfe4a5d9465b48e0aab7277e59b3eb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.