Closed
Bug 1075442
Opened 10 years ago
Closed 10 years ago
JS engine's using external/stlport on Firefox OS
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: laszio.bugzilla, Assigned: laszio.bugzilla)
Details
Attachments
(1 file)
958 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
JS engine uses external/stlport while other components of Gecko uses gecko/build/stlport. They have different configurations, such as internal allocators, and may be of different versions. Using external/stlport suffers from bugs like: Bug 850576 - Some (all?) STL allocations use libc's malloc instead of jemalloc Bug 861973 - STLport shouldn't use its own allocator
Assignee | ||
Comment 1•10 years ago
|
||
Hi Glandium, the fix should be simply make js/src use gecko/build/stlport, right?
Attachment #8498081 -
Flags: feedback?(mh+mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8498081 [details] [diff] [review] stlport.patch Review of attachment 8498081 [details] [diff] [review]: ----------------------------------------------------------------- It's only a theoretical problem. I don't expect anything really changing from this patch, except consistency between configure.in and js/src/configure.in.
Attachment #8498081 -
Flags: feedback?(mh+mozilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
> It's only a theoretical problem. I don't expect anything really changing
> from this patch, except consistency between configure.in and
> js/src/configure.in.
Thanks for reviewing this. I think it could be a potential problem. Although crashes only happened when containers are used (only for experiments), I'm also seeing several existing files which include <string>. Although not directly related to allocators, some include <algorithm> and I'm not sure if different versions and configurations would work properly.
Assignee | ||
Comment 4•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5fb93464d74b
Whiteboard: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/97974cf0eb91
Assignee: nobody → thuang
Updated•10 years ago
|
Whiteboard: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/97974cf0eb91
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•