1075463 - Unable to login with email addresses longer than 30 characters

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[:gerard-majax]

STR:
 0. Click "Login"
 1. Complete the Persona login flow (that works on a lot of other Persona sites users)

Expected:
 I'm logged in

Actual:
 I still have the "Login/Register" button.

My Persona ID is the same as my bugzilla mail.

Comment 1

[Mauro Doglio [:mdoglio]]

I saw the following trace on new relic
https://rpm.newrelic.com/accounts/677903/applications/4180461/traced_errors/2299261752
The username field is not big enough for that email, we may need to either increase the size of that field or fill it with some surrogate.

Comment 2

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/migrations/0001_initial.py#L339
> 'username': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '30'})

This isn't P1 compared to some of the other issues that need to be dealt with first on https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Non-blocking_regressions , but will be looked at soon. (I'm trying to curate 5-10 top P1 issues to focus current work)

Comment 3

[Ed Morley [:emorley]]

http://logs.glob.uno/?c=mozilla%23b2g#c215892
12:54	gerard-majax	I asked for help a month ago
12:54	gerard-majax	nobody cared
...
12:59	gerard-majax	it's non blocking ...
12:59	gerard-majax	I don't feel this very comforting

Alexandre, when replying in comment 2, I specifically linked to the wiki to try and help you understand that it's not that this issue isn't important, but that there were/are more critical bugs that need to be resolved first - like data loss. In addition, the wiki page has descriptions for the milestones & the current status of switching to treeherder, which from the IRC log I believe you may not have seen. 

The description for the particular bug table I linked to in comment 2 is:
"Remaining regressions/pain points compared to TBPL that are not blocking sheriff transition."

The sheriffs are now using treeherder only, but it's up to others whether they use TBPL or treeherder in this interim period whilst remaining regression bugs are fixed.

If you have any questions about roadmap/prioritisation - or wish to ask here to get an idea of timeframe, I'm more than happy to try and answer, but without a reply here it's impossible to know that you weren't quite happy continuing to use TBPL in the meantime.

Comment 4

[:gerard-majax]

Still no news ?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to pull request 319

No clue if this actually works.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8546786 [details] [review]
Link to pull request 319

The schema needs migrating too, eg like:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/migrations/0001_initial.py

Comment 7

[Mauro Doglio [:mdoglio]]

I wouldn't change the db schema to solve this.
We are currently creating the username from the user email and we can just stop doing it.
We can just generate the username with a hash of the email (this is actually the default behaviour for django-browserid) and show the email in the ui instead of the username.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/9cb2359e34f118b3eb14cfa92deb73507cc17505
Bug 1075463 - Remove persona custom username creation

Comment 9

[Mauro Doglio [:mdoglio]]

Attachment: PR 321 on treeherder-service

:edmorley gave a r+ on github to this

Comment 10

[Mauro Doglio [:mdoglio]]

It's on stage now, it will likely go to prod tomorrow

Comment 11

[:gerard-majax]

I have been able to login on treeherder now, thanks!

Comment 12

[Ed Morley [:emorley]]

Sorry this took so long! :-)