Closed Bug 1075563 Opened 8 years ago Closed 8 years ago

flake8 not installed in dev environment

Categories

(Input Graveyard :: Code Quality, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=dev c=codequality p=1 s=input.2014q4)

If you follow the instructions in the Getting Started guide, you end up with a vm with a virtual environment that doesn't have flake8 installed. Because you don't have flake8 installed, if you add the pre-commit hook, you won't be able to commit any changes.

This bug covers fixing the situation so you do have flake8 installed.

I think we should create another requirements file for development that includes development-specific things like flake8 and that recursively adds the other requirements files. Then we change the vagrant provisioning script to install that one and we change the instructions to always use that one.
Fixed in https://github.com/mozilla/fjord/commit/7540394cddf609dacc27791aaeef00d02a44170b

I just tweaked the documentation. We can think about an additional requirements file later.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → willkg
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.