Closed Bug 1075591 Opened 5 years ago Closed 5 years ago

js::gc::TenuredCell::asTenured should return a TenuredCell &, not a TenuredCell *

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

js::gc::TenuredCell::asTenured should return a TenuredCell &, not a TenuredCell *, since the return pointer is known to be non-null, and for consistency with the other asBlah methods in js/src.
Attachment #8498207 - Flags: review?(terrence)
Assignee: nobody → jimb
Comment on attachment 8498207 [details] [diff] [review]
Make js::gc::TenuredCell::asTenured return a TenuredCell &, not a TenuredCell *.

Review of attachment 8498207 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8498207 - Flags: review?(terrence) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a59c2ddcf04c
Flags: in-testsuite-
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/a59c2ddcf04c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.